opendev/gerrit
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update plugins/replication from branch 'stable-3.0'
  to 8060f5f77fa8d48c9ef357501fbbdad56b7217c6
  - Merge branch 'stable-2.16' into stable-3.0
    
    * stable-2.16:
      ReplicationQueue: Revert back from Flogger to slf4j logging
    
    Change-Id: I82c8399626ed53331e18128a7979cb8e68bfa5f1
    
  - ReplicationQueue: Revert back from Flogger to slf4j logging
    
    Slf4j's Mapped Diagnostic Context (MDC) is used to add the replication Id
    into the logs and this was not adapted in the migration to Flogger,
    resulting in the replication Id being omitted from the logs.
    
    Flogger does not support MDC in the same way as slf4j, but provides a log
    context which could be used. This would however change the format of the log
    output. An alternative would be to manually update all the log statements
    to include the replication Id. The downside of this approach is that we
    need to remember to manually add it in any new logs that get added.
    
    Instead of attempting either of those, just revert back to using slf4j.
    
    This reverts commit 425f4f20218986615593da1a9319466743ee12eb.
    
    Note that this is not a pure revert of 425f4f2; following that commit
    several new logs were added. This reverts the commit and adapts the new
    logs to also use slf4j.
    
    Bug: Issue 12678
    Change-Id: I3002afdac7c31786de5b611b32fa3f4c1a80e657
This commit is contained in:
David Pursehouse
2020-05-09 01:31:16 +09:00
committed by Gerrit Code Review
parent f6eb1df79d
commit 4a36adec13
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files