Merge branch 'stable-2.8'
* stable-2.8: Comment Added stream event should be fired even if mail is not sent Update the revision of the cookbook plugin Fix minor typo in REST API accounts documentation Change-Id: I5a74825e06ef0906b637e30877d6b10d5ec1b00a
This commit is contained in:
commit
4b0fceae0b
@ -113,7 +113,7 @@ If the account does not have a name an empty string is returned.
|
||||
Sets the full name of an account.
|
||||
|
||||
The new account name must be provided in the request body inside
|
||||
a link:#account-name-input[AccountNameInput] entity.
|
||||
an link:#account-name-input[AccountNameInput] entity.
|
||||
|
||||
.Request
|
||||
----
|
||||
|
@ -156,14 +156,16 @@ public class PostReview implements RestModifyView<RevisionResource, ReviewInput>
|
||||
} else {
|
||||
indexWrite = Futures.<Void, IOException> immediateCheckedFuture(null);
|
||||
}
|
||||
if (input.notify.compareTo(NotifyHandling.NONE) > 0 && message != null) {
|
||||
email.create(
|
||||
input.notify,
|
||||
change,
|
||||
revision.getPatchSet(),
|
||||
revision.getAccountId(),
|
||||
message,
|
||||
comments).sendAsync();
|
||||
if (message != null) {
|
||||
if (input.notify.compareTo(NotifyHandling.NONE) > 0) {
|
||||
email.create(
|
||||
input.notify,
|
||||
change,
|
||||
revision.getPatchSet(),
|
||||
revision.getAccountId(),
|
||||
message,
|
||||
comments).sendAsync();
|
||||
}
|
||||
fireCommentAddedHook(revision);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user