opendev/gerrit
Code Issues Proposed changes

Error Prone: Enable and fix ClassCanBeStatic

Browse Source 
Change-Id: Ice8202695c2a525d751682185e1aa94663e0fbe0
This commit is contained in:
Dave Borowitz
2019-05-24 10:15:40 -07:00
committed by David Pursehouse
parent 8f0c2bb911
commit 4b25dd3c15
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javatests/com/google/gerrit/server/account/AccountResolverTest.java
View File

@@ -37,7 +37,7 @@ import java.util.stream.Stream;
import org.junit.Test;
public class AccountResolverTest extends GerritBaseTests {
private class TestSearcher extends StringSearcher {
private static class TestSearcher extends StringSearcher {
private final String pattern;
private final boolean shortCircuit;
private final ImmutableList<AccountState> accounts;

2
tools/BUILD
View File

@@ -30,7 +30,7 @@ java_package_configuration(
"-Xep:BadComparable:WARN",
"-Xep:BoxedPrimitiveConstructor:ERROR",
"-Xep:CannotMockFinalClass:WARN",
"-Xep:ClassCanBeStatic:WARN",
"-Xep:ClassCanBeStatic:ERROR",
"-Xep:ClassNewInstance:WARN",
"-Xep:DateFormatConstant:ERROR",
"-Xep:DefaultCharset:ERROR",