Do not crash if permitted labels array is empty
Bug: Issue 9909
Change-Id: Ia4b3a2af7eafb23e314ebac300d5f3e589bf9c72
(cherry picked from commit c03bb0f454
)
This commit is contained in:
parent
7b8b18289c
commit
57d29e919b
@ -69,7 +69,8 @@
|
|||||||
},
|
},
|
||||||
|
|
||||||
_computeBlankItems(permittedLabels, label, side) {
|
_computeBlankItems(permittedLabels, label, side) {
|
||||||
if (!permittedLabels || !permittedLabels[label] || !this.labelValues ||
|
if (!permittedLabels || !permittedLabels[label] ||
|
||||||
|
!permittedLabels[label].length || !this.labelValues ||
|
||||||
!Object.keys(this.labelValues).length) {
|
!Object.keys(this.labelValues).length) {
|
||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
@ -135,7 +136,8 @@
|
|||||||
},
|
},
|
||||||
|
|
||||||
_computeAnyPermittedLabelValues(permittedLabels, label) {
|
_computeAnyPermittedLabelValues(permittedLabels, label) {
|
||||||
return permittedLabels.hasOwnProperty(label);
|
return permittedLabels.hasOwnProperty(label) &&
|
||||||
|
permittedLabels[label].length;
|
||||||
},
|
},
|
||||||
|
|
||||||
_computeHiddenClass(permittedLabels, label) {
|
_computeHiddenClass(permittedLabels, label) {
|
||||||
|
@ -258,6 +258,11 @@ limitations under the License.
|
|||||||
flushAsynchronousOperations();
|
flushAsynchronousOperations();
|
||||||
assert.isOk(element.$$('iron-selector'));
|
assert.isOk(element.$$('iron-selector'));
|
||||||
assert.isTrue(element.$$('iron-selector').hidden);
|
assert.isTrue(element.$$('iron-selector').hidden);
|
||||||
|
|
||||||
|
element.permittedLabels = {Verified: []};
|
||||||
|
flushAsynchronousOperations();
|
||||||
|
assert.isOk(element.$$('iron-selector'));
|
||||||
|
assert.isTrue(element.$$('iron-selector').hidden);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('asymetrical labels', () => {
|
test('asymetrical labels', () => {
|
||||||
|
Loading…
Reference in New Issue
Block a user