opendev/gerrit
Code Issues Proposed changes

Reload change when vote is deleted

Browse Source 
Bug: Issue 7555
Change-Id: Ifd76847baa7a1042a090c46bb6762511ecbe172f
This commit is contained in:
Kasper Nilsson
2018-11-12 09:53:48 -08:00
parent df2a0c888d
commit 5e8b7e7299
1 changed files with 2 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
View File

@@ -127,27 +127,8 @@
this.$.restAPI.deleteVote(this.change._number, accountID, this.label)
.then(response => {
target.disabled = false;
if (!response.ok) { return response; }
const label = this.change.labels[this.label];
const labels = label.all || [];
let wasChanged = false;
for (let i = 0; i < labels.length; i++) {
if (labels[i]._account_id === accountID) {
for (const key in label) {
if (label.hasOwnProperty(key) &&
label[key]._account_id === accountID) {
// Remove special label field, keeping change label values
// in sync with the backend.
this.change.labels[this.label][key] = null;
}
}
this.change.labels[this.label].all.splice(i, 1);
wasChanged = true;
break;
}
}
if (wasChanged) { this.notifySplices('change.labels'); }
if (!response.ok) { return; }
Gerrit.Nav.navigateToChange(this.change);
}).catch(err => {
target.disabled = false;
return;