opendev/gerrit
Code Issues Proposed changes

Do not show backdrop in reviewer confirmation overlay

Browse Source 
If the user adds a group with a size greater than the configured
addreviewer.maxWithoutConfirmation limit, Gerrit will show a confirm
dialog (nested within the reply dialog) to prevent accidentally adding
large numbers of reviewers.

When it was first implemented in I0a61819e78, the dialog enabled the
overlay backdrop (in addition to the reply dialog backdrop), but that
backdrop was either not working initially, or it stopped appearing in
the intervening time.

Problematically, newer versions of iron-overlay-behavior will attempt to
honor the backdrop option in the nested dialog, but does so in such a
way that the overlay appears over the dialog, and the buttons are not
clickable.

With this change, the backdrop is disabled.

Bug: Issue 8353
Change-Id: Ia30613f4ea99edde6d5c9a1c2261e8b5e16d32b4
This commit is contained in:
Wyatt Allen
2018-02-20 17:22:49 -08:00
parent 4b89b3707b
commit 6147bd1664
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -171,8 +171,7 @@ limitations under the License.
</template>
<gr-overlay
id="reviewerConfirmationOverlay"
on-iron-overlay-canceled="_cancelPendingReviewer"
with-backdrop>
on-iron-overlay-canceled="_cancelPendingReviewer">
<div class="reviewerConfirmation">
Group
<span class="groupName">