opendev/gerrit
Code Issues Proposed changes

Rewrite on-tap to on-click

Browse Source 
Polymer recommends to prefer click events over Polymer tap events.
Performance on initializing on-click is much better than on-tap.

https://polymer-library.polymer-project.org/2.0/docs/devguide/gesture-events

Change-Id: I0aec1ddcc9ad74f7880e7fd7ca0689b5c8c84796
This commit is contained in:
Milutin Kristofic
2019-09-27 15:41:53 +02:00
parent bfa2a6e897
commit 63cf95d19d
52 changed files with 128 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.html
View File

@@ -97,7 +97,7 @@ limitations under the License.
id="editBtn"
link
class$="[[_computeEditBtnClass(section.id)]]"
on-tap="editReference">
on-click="editReference">
<iron-icon id="icon" icon="gr-icons:create"></iron-icon>
</gr-button>
</div>
@@ -116,7 +116,7 @@ limitations under the License.
<gr-button
link
id="deleteBtn"
on-tap="_handleRemoveReference">Remove</gr-button>
on-click="_handleRemoveReference">Remove</gr-button>
</div><!-- end header -->
<div class="sectionContent">
<template
@@ -147,7 +147,7 @@ limitations under the License.
<gr-button
link
id="addBtn"
on-tap="_handleAddPermission">Add</gr-button>
on-click="_handleAddPermission">Add</gr-button>
</div>
<!-- end addPermission -->
</div><!-- end sectionContent -->
@@ -157,7 +157,7 @@ limitations under the License.
<gr-button
link
id="undoRemoveBtn"
on-tap="_handleUndoRemove">Undo</gr-button>
on-click="_handleUndoRemove">Undo</gr-button>
</div><!-- end deletedContainer -->
</fieldset>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

8
polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.html
View File

@@ -91,7 +91,7 @@ limitations under the License.
</span>
<gr-button
id="saveGroupMember"
on-tap="_handleSavingGroupMember"
on-click="_handleSavingGroupMember"
disabled="[[!_groupMemberSearchId]]">
Add
</gr-button>
@@ -111,7 +111,7 @@ limitations under the License.
<td class="deleteColumn">
<gr-button
class="deleteMembersButton"
on-tap="_handleDeleteMember">
on-click="_handleDeleteMember">
Delete
</gr-button>
</td>
@@ -133,7 +133,7 @@ limitations under the License.
</span>
<gr-button
id="saveIncludedGroups"
on-tap="_handleSavingIncludedGroups"
on-click="_handleSavingIncludedGroups"
disabled="[[!_includedGroupSearchId]]">
Add
</gr-button>
@@ -163,7 +163,7 @@ limitations under the License.
<td class="deleteColumn">
<gr-button
class="deleteIncludedGroupButton"
on-tap="_handleDeleteIncludedGroup">
on-click="_handleDeleteIncludedGroup">
Delete
</gr-button>
</td>

8
polygerrit-ui/app/elements/admin/gr-group/gr-group.html
View File

@@ -66,7 +66,7 @@ limitations under the License.
<span class="value" disabled$="[[_computeGroupDisabled(_groupOwner, _isAdmin, _groupIsInternal)]]">
<gr-button
id="inputUpdateNameBtn"
on-tap="_handleSaveName"
on-click="_handleSaveName"
disabled="[[!_rename]]">
Rename Group</gr-button>
</span>
@@ -86,7 +86,7 @@ limitations under the License.
</span>
<span class="value" disabled$="[[_computeGroupDisabled(_groupOwner, _isAdmin, _groupIsInternal)]]">
<gr-button
on-tap="_handleSaveOwner"
on-click="_handleSaveOwner"
disabled="[[!_owner]]">
Change Owners</gr-button>
</span>
@@ -104,7 +104,7 @@ limitations under the License.
</div>
<span class="value" disabled$="[[_computeGroupDisabled(_groupOwner, _isAdmin, _groupIsInternal)]]">
<gr-button
on-tap="_handleSaveDescription"
on-click="_handleSaveDescription"
disabled="[[!_description]]">
Save Description
</gr-button>
@@ -132,7 +132,7 @@ limitations under the License.
</section>
<span class="value" disabled$="[[_computeGroupDisabled(_groupOwner, _isAdmin, _groupIsInternal)]]">
<gr-button
on-tap="_handleSaveOptions"
on-click="_handleSaveOptions"
disabled="[[!_options]]">
Save Group Options
</gr-button>

4
polygerrit-ui/app/elements/admin/gr-permission/gr-permission.html
View File

@@ -101,7 +101,7 @@ limitations under the License.
<gr-button
link
id="removeBtn"
on-tap="_handleRemovePermission">Remove</gr-button>
on-click="_handleRemovePermission">Remove</gr-button>
</div>
</div><!-- end header -->
<div class="rules">
@@ -137,7 +137,7 @@ limitations under the License.
<gr-button
link
id="undoRemoveBtn"
on-tap="_handleUndoRemove">Undo</gr-button>
on-click="_handleUndoRemove">Undo</gr-button>
</div><!-- end deletedContainer -->
</section>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

4
polygerrit-ui/app/elements/admin/gr-plugin-config-array-editor/gr-plugin-config-array-editor.html
View File

@@ -74,7 +74,7 @@ limitations under the License.
link
disabled$="[[disabled]]"
data-item="[[item]]"
on-tap="_handleDelete">Delete</gr-button>
on-click="_handleDelete">Delete</gr-button>
</div>
</template>
</div>
@@ -96,7 +96,7 @@ limitations under the License.
id="addButton"
disabled$="[[!_newValue.length]]"
link
on-tap="_handleAddTap">Add</gr-button>
on-click="_handleAddTap">Add</gr-button>
</div>
</div>
</template>

8
polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.html
View File

@@ -96,16 +96,16 @@ limitations under the License.
</template>
</div>
<gr-button id="editBtn"
on-tap="_handleEdit">[[_editOrCancel(_editing)]]</gr-button>
on-click="_handleEdit">[[_editOrCancel(_editing)]]</gr-button>
<gr-button id="saveBtn"
primary
class$="[[_computeSaveBtnClass(_ownerOf)]]"
on-tap="_handleSave"
on-click="_handleSave"
disabled$="[[!_modified]]">Save</gr-button>
<gr-button id="saveReviewBtn"
primary
class$="[[_computeSaveReviewBtnClass(_canUpload)]]"
on-tap="_handleSaveForReview"
on-click="_handleSaveForReview"
disabled$="[[!_modified]]">Save for review</gr-button>
<template
is="dom-repeat"
@@ -125,7 +125,7 @@ limitations under the License.
</template>
<div class="referenceContainer">
<gr-button id="addReferenceBtn"
on-tap="_handleCreateSection">Add Reference</gr-button>
on-click="_handleCreateSection">Add Reference</gr-button>
</div>
</div>
</main>

3
polygerrit-ui/app/elements/admin/gr-repo-command/gr-repo-command.html
View File

@@ -30,7 +30,8 @@ limitations under the License.
<gr-button
title$="[[tooltip]]"
disabled$="[[disabled]]"
on-tap="_onCommandTap">
on-click
="_onCommandTap">
[[title]]
</gr-button>
</template>

8
polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.html
View File

@@ -121,7 +121,7 @@ limitations under the License.
</span>
<gr-button
link
on-tap="_handleEditRevision"
on-click="_handleEditRevision"
class="editBtn">
edit
</gr-button>
@@ -134,13 +134,13 @@ limitations under the License.
</iron-input>
<gr-button
link
on-tap="_handleCancelRevision"
on-click="_handleCancelRevision"
class="cancelBtn editItem">
Cancel
</gr-button>
<gr-button
link
on-tap="_handleSaveRevision"
on-click="_handleSaveRevision"
class="saveBtn editItem"
disabled="[[!_revisedRef]]">
Save
@@ -176,7 +176,7 @@ limitations under the License.
<gr-button
link
class$="deleteButton [[_computeHideDeleteClass(_isOwner, item.can_delete)]]"
on-tap="_handleDeleteItem">
on-click="_handleDeleteItem">
Delete
</gr-button>
</td>

2
polygerrit-ui/app/elements/admin/gr-repo/gr-repo.html
View File

@@ -363,7 +363,7 @@ limitations under the License.
</template>
</div>
<gr-button
on-tap="_handleSaveRepoConfig"
on-click="_handleSaveRepoConfig"
disabled$="[[_computeButtonDisabled(_readOnly, _configChanged)]]">Save changes</gr-button>
</fieldset>
<gr-endpoint-decorator name="repo-config">

4
polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.html
View File

@@ -147,14 +147,14 @@ limitations under the License.
<gr-button
link
id="removeBtn"
on-tap="_handleRemoveRule">Remove</gr-button>
on-click="_handleRemoveRule">Remove</gr-button>
</div>
<div
id="deletedContainer"
class$="gr-form-styles [[_computeSectionClass(editing, _deleted)]]">
[[groupName]] was deleted
<gr-button link
id="undoRemoveBtn" on-tap="_handleUndoRemove">Undo</gr-button>
id="undoRemoveBtn" on-click="_handleUndoRemove">Undo</gr-button>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

2
polygerrit-ui/app/elements/change-list/gr-create-change-help/gr-create-change-help.html
View File

@@ -82,7 +82,7 @@ limitations under the License.
other git code review tools. Click on the `Create Change' button
and follow the step by step instructions.
</p>
<gr-button on-tap="_handleCreateTap">Create Change</gr-button>
<gr-button on-click="_handleCreateTap">Create Change</gr-button>
</div>
</template>
<script src="gr-create-change-help.js"></script>

2
polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.html
View File

@@ -81,7 +81,7 @@ limitations under the License.
<gr-button
class="delete"
link
on-tap="_handleOpenDeleteDialog">Delete All</gr-button>
on-click="_handleOpenDeleteDialog">Delete All</gr-button>
</div>
</div>
<div class="loading" hidden$="[[!_loading]]">Loading...</div>

4
polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
View File

@@ -128,7 +128,7 @@ limitations under the License.
data-action-type$="[[action.__type]]"
data-label$="[[action.label]]"
disabled$="[[_calculateDisabled(action, _hasKnownChainState)]]"
on-tap="_handleActionTap">
on-click="_handleActionTap">
<iron-icon class$="[[_computeHasIcon(action)]]" icon$="gr-icons:[[action.icon]]"></iron-icon>
[[action.label]]
</gr-button>
@@ -148,7 +148,7 @@ limitations under the License.
data-action-type$="[[action.__type]]"
data-label$="[[action.label]]"
disabled$="[[_calculateDisabled(action, _hasKnownChainState)]]"
on-tap="_handleActionTap">
on-click="_handleActionTap">
<iron-icon class$="[[_computeHasIcon(action)]]" icon$="gr-icons:[[action.icon]]"></iron-icon>
[[action.label]]
</gr-button>

8
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
View File

@@ -453,7 +453,7 @@ limitations under the License.
hidden$="[[!_loggedIn]]"
primary
disabled="[[_replyDisabled]]"
on-tap="_handleReplyTap">[[_replyButtonLabel]]</gr-button>
on-click="_handleReplyTap">[[_replyButtonLabel]]</gr-button>
</div>
<div
id="commitMessage"
@@ -470,7 +470,7 @@ limitations under the License.
</gr-editable-content>
<gr-button link
class="editCommitMessage"
on-tap="_handleEditCommitMessage"
on-click="_handleEditCommitMessage"
hidden$="[[_hideEditCommitMessage]]">Edit</gr-button>
<div class="changeId" hidden$="[[!_changeIdCommitMessageError]]">
<hr>
@@ -490,7 +490,7 @@ limitations under the License.
link
id="commitCollapseToggleButton"
class="collapseToggleButton"
on-tap="_toggleCommitCollapsed">
on-click="_toggleCommitCollapsed">
[[_computeCollapseText(_commitCollapsed)]]
</gr-button>
</div>
@@ -518,7 +518,7 @@ limitations under the License.
link
id="relatedChangesToggleButton"
class="collapseToggleButton"
on-tap="_toggleRelatedChangesCollapsed">
on-click="_toggleRelatedChangesCollapsed">
[[_computeCollapseText(_relatedChangesCollapsed)]]
</gr-button>
</div>

2
polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.html
View File

@@ -121,7 +121,7 @@ limitations under the License.
<span class="closeButtonContainer">
<gr-button id="closeButton"
link
on-tap="_handleCloseTap">Close</gr-button>
on-click="_handleCloseTap">Close</gr-button>
</span>
</section>
</template>

12
polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html
View File

@@ -217,28 +217,28 @@ limitations under the License.
<span class$="[[_computeUploadHelpContainerClass(change, account)]]">
<gr-button link
class="upload"
on-tap="_handleUploadTap">Update Change</gr-button>
on-click="_handleUploadTap">Update Change</gr-button>
</span>
<span class="downloadContainer desktop">
<gr-button link
class="download"
on-tap="_handleDownloadTap">Download</gr-button>
on-click="_handleDownloadTap">Download</gr-button>
</span>
<span class$="includedInContainer [[_hideIncludedIn(change)]] desktop">
<gr-button link
class="includedIn"
on-tap="_handleIncludedInTap">Included In</gr-button>
on-click="_handleIncludedInTap">Included In</gr-button>
</span>
<template is="dom-if"
if="[[_fileListActionsVisible(shownFileCount, _maxFilesForBulkActions)]]">
<gr-button
id="expandBtn"
link
on-tap="_expandAllDiffs">Expand All</gr-button>
on-click="_expandAllDiffs">Expand All</gr-button>
<gr-button
id="collapseBtn"
link
on-tap="_collapseAllDiffs">Collapse All</gr-button>
on-click="_collapseAllDiffs">Collapse All</gr-button>
</template>
<template is="dom-if"
if="[[!_fileListActionsVisible(shownFileCount, _maxFilesForBulkActions)]]">
@@ -262,7 +262,7 @@ limitations under the License.
has-tooltip
title="Diff preferences"
class="prefsButton desktop"
on-tap="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
on-click="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
</span>
</div>
</div>

4
polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.html
View File

@@ -451,7 +451,7 @@ limitations under the License.
<gr-button
class="fileListButton"
id="incrementButton"
link on-tap="_incrementNumFilesShown">
link on-click="_incrementNumFilesShown">
[[_computeIncrementText(numFilesShown, _files)]]
</gr-button>
<gr-tooltip-content
@@ -461,7 +461,7 @@ limitations under the License.
<gr-button
class="fileListButton"
id="showAllButton"
link on-tap="_showAllFiles">
link on-click="_showAllFiles">
[[_computeShowAllText(_files)]]
</gr-button><!--
--></gr-tooltip-content>

2
polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.html
View File

@@ -77,7 +77,7 @@ limitations under the License.
<span class="closeButtonContainer">
<gr-button id="closeButton"
link
on-tap="_handleCloseTap">Close</gr-button>
on-click="_handleCloseTap">Close</gr-button>
</span>
<iron-input
placeholder="Filter"

2
polygerrit-ui/app/elements/change/gr-message/gr-message.html
View File

@@ -199,7 +199,7 @@ limitations under the License.
content="[[message.message]]"
config="[[_projectConfig.commentlinks]]"></gr-formatted-text>
<div class="replyContainer" hidden$="[[!showReplyButton]]" hidden>
<gr-button link small on-tap="_handleReplyTap">Reply</gr-button>
<gr-button link small on-click="_handleReplyTap">Reply</gr-button>
</div>
<gr-comment-list
comments="[[comments]]"

6
polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html
View File

@@ -78,14 +78,14 @@ limitations under the License.
<gr-button
id="collapse-messages"
link
on-tap="_handleExpandCollapseTap">
on-click="_handleExpandCollapseTap">
[[_computeExpandCollapseMessage(_expanded)]]
</gr-button>
</div>
<span
id="messageControlsContainer"
hidden$="[[_computeShowHideTextHidden(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]">
<gr-button id="oldMessagesBtn" link on-tap="_handleShowAllTap">
<gr-button id="oldMessagesBtn" link on-click="_handleShowAllTap">
[[_computeNumMessagesText(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]
</gr-button>
<span
@@ -93,7 +93,7 @@ limitations under the License.
hidden$="[[_computeIncrementHidden(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]">
<span class="transparent separator"></span>
<gr-button id="incrementMessagesBtn" link
on-tap="_handleIncrementShownMessages">
on-click="_handleIncrementShownMessages">
[[_computeIncrementText(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]
</gr-button>
</span>

12
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -204,8 +204,8 @@ limitations under the License.
Are you sure you want to add them all?
</div>
<div class="reviewerConfirmationButtons">
<gr-button on-tap="_confirmPendingReviewer">Yes</gr-button>
<gr-button on-tap="_cancelPendingReviewer">No</gr-button>
<gr-button on-click="_confirmPendingReviewer">Yes</gr-button>
<gr-button on-click="_cancelPendingReviewer">No</gr-button>
</div>
</gr-overlay>
</section>
@@ -276,7 +276,7 @@ limitations under the License.
class="action save"
has-tooltip
title="[[_saveTooltip]]"
on-tap="_saveTapHandler">Save</gr-button>
on-click="_saveTapHandler">Save</gr-button>
</template>
<span
id="checkingStatusLabel"
@@ -287,7 +287,7 @@ limitations under the License.
id="notLatestLabel"
hidden$="[[!_isState(knownLatestState, 'not-latest')]]">
[[_computePatchSetWarning(patchNum, _labelsChanged)]]
<gr-button link on-tap="_reload">Reload</gr-button>
<gr-button link on-click="_reload">Reload</gr-button>
</span>
</div>
<div class="right">
@@ -295,7 +295,7 @@ limitations under the License.
link
id="cancelButton"
class="action cancel"
on-tap="_cancelTapHandler">Cancel</gr-button>
on-click="_cancelTapHandler">Cancel</gr-button>
<gr-button
id="sendButton"
link
@@ -304,7 +304,7 @@ limitations under the License.
class="action send"
has-tooltip
title$="[[_computeSendButtonTooltip(canBeStarted)]]"
on-tap="_sendTapHandler">[[_sendButtonLabel]]</gr-button>
on-click="_sendTapHandler">[[_sendButtonLabel]]</gr-button>
</div>
</section>
</div>

4
polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.html
View File

@@ -71,13 +71,13 @@ limitations under the License.
class="hiddenReviewers"
link
hidden$="[[!_hiddenReviewerCount]]"
on-tap="_handleViewAll">and [[_hiddenReviewerCount]] more</gr-button>
on-click="_handleViewAll">and [[_hiddenReviewerCount]] more</gr-button>
<div class="controlsContainer" hidden$="[[!mutable]]">
<gr-button
link
id="addReviewer"
class="addReviewer"
on-tap="_handleAddTap">[[_addLabel]]</gr-button>
on-click="_handleAddTap">[[_addLabel]]</gr-button>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
</template>

2
polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.html
View File

@@ -63,7 +63,7 @@ limitations under the License.
</style>
<header>
<h3>Keyboard shortcuts</h3>
<gr-button link on-tap="_handleCloseTap">Close</gr-button>
<gr-button link on-click="_handleCloseTap">Close</gr-button>
</header>
<main>
<table>

4
polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.html
View File

@@ -41,7 +41,7 @@ limitations under the License.
has-tooltip
class$="[[_computeSelectedClass(mode, _VIEW_MODES.SIDE_BY_SIDE)]]"
title="Side-by-side diff"
on-tap="_handleSideBySideTap">
on-click="_handleSideBySideTap">
<iron-icon icon="gr-icons:side-by-side"></iron-icon>
</gr-button>
<gr-button
@@ -50,7 +50,7 @@ limitations under the License.
has-tooltip
title="Unified diff"
class$="[[_computeSelectedClass(mode, _VIEW_MODES.UNIFIED)]]"
on-tap="_handleUnifiedTap">
on-click="_handleUnifiedTap">
<iron-icon icon="gr-icons:unified"></iron-icon>
</gr-button>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

4
polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.html
View File

@@ -64,13 +64,13 @@ limitations under the License.
<gr-button
id="cancelButton"
link
on-tap="_handleCancelDiff">
on-click="_handleCancelDiff">
Cancel
</gr-button>
<gr-button
id="saveButton"
link primary
on-tap="_handleSaveDiffPreferences"
on-click="_handleSaveDiffPreferences"
disabled$="[[!_diffPrefsChanged]]">
Save
</gr-button>

4
polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html
View File

@@ -281,7 +281,7 @@ limitations under the License.
<gr-button
link
disabled="[[_isBlameLoading]]"
on-tap="_toggleBlame">[[_computeBlameToggleLabel(_isBlameLoaded, _isBlameLoading)]]</gr-button>
on-click="_toggleBlame">[[_computeBlameToggleLabel(_isBlameLoaded, _isBlameLoading)]]</gr-button>
<span class="separator"></span>
</span>
<div class$="diffModeSelector [[_computeModeSelectHideClass(_isImageDiff)]]">
@@ -299,7 +299,7 @@ limitations under the License.
class="prefsButton"
has-tooltip
title="Diff preferences"
on-tap="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
on-click="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
</span>
</span>
<gr-endpoint-decorator name="annotation-toggler">

4
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
View File

@@ -406,10 +406,10 @@ limitations under the License.
Prevented render because "Whole file" is enabled and this diff is very
large (about [[_diffLength]] lines).
</p>
<gr-button on-tap="_handleLimitedBypass">
<gr-button on-click="_handleLimitedBypass">
Render with limited context
</gr-button>
<gr-button on-tap="_handleFullBypass">
<gr-button on-click="_handleFullBypass">
Render anyway (may be slow)
</gr-button>
</div>

2
polygerrit-ui/app/elements/edit/gr-edit-controls/gr-edit-controls.html
View File

@@ -84,7 +84,7 @@ limitations under the License.
id$="[[action.id]]"
class$="[[_computeIsInvisible(action.id, hiddenActions)]]"
link
on-tap="_handleTap">[[action.label]]</gr-button>
on-click="_handleTap">[[action.label]]</gr-button>
</template>
<gr-overlay id="overlay" with-backdrop>
<gr-dialog

4
polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.html
View File

@@ -102,13 +102,13 @@ limitations under the License.
<gr-button
id="close"
link
on-tap="_handleCloseTap">Close</gr-button>
on-click="_handleCloseTap">Close</gr-button>
<gr-button
id="save"
disabled$="[[_saveDisabled]]"
primary
link
on-tap="_saveEdit">Save</gr-button>
on-click="_saveEdit">Save</gr-button>
</span>
</header>
</gr-fixed-panel>

2
polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.html
View File

@@ -103,7 +103,7 @@ limitations under the License.
bind-value="{{_agreementsText}}"
placeholder="Enter 'I agree' here">
</iron-input>
<gr-button on-tap="_handleSaveAgreements" disabled="[[_disableAgreementsText(_agreementsText)]]">
<gr-button on-click="_handleSaveAgreements" disabled="[[_disableAgreementsText(_agreementsText)]]">
Submit
</gr-button>
</div>

2
polygerrit-ui/app/elements/settings/gr-email-editor/gr-email-editor.html
View File

@@ -83,7 +83,7 @@ limitations under the License.
<td>
<gr-button
data-index$="[[index]]"
on-tap="_handleDeleteButton"
on-click="_handleDeleteButton"
disabled="[[item.preferred]]"
class="remove-button">Delete</gr-button>
</td>

10
polygerrit-ui/app/elements/settings/gr-gpg-editor/gr-gpg-editor.html
View File

@@ -76,14 +76,14 @@ limitations under the License.
</td>
<td class="keyHeader">
<gr-button
on-tap="_showKey"
on-click="_showKey"
data-index$="[[index]]"
link>Click to View</gr-button>
</td>
<td>
<gr-button
data-index$="[[index]]"
on-tap="_handleDeleteKey">Delete</gr-button>
on-click="_handleDeleteKey">Delete</gr-button>
</td>
</tr>
</template>
@@ -102,10 +102,10 @@ limitations under the License.
</fieldset>
<gr-button
class="closeButton"
on-tap="_closeOverlay">Close</gr-button>
on-click="_closeOverlay">Close</gr-button>
</gr-overlay>
<gr-button
on-tap="save"
on-click="save"
disabled$="[[!hasUnsavedChanges]]">Save changes</gr-button>
</fieldset>
<fieldset>
@@ -122,7 +122,7 @@ limitations under the License.
<gr-button
id="addButton"
disabled$="[[_computeAddButtonDisabled(_newKey)]]"
on-tap="_handleAddKey">Add new GPG key</gr-button>
on-click="_handleAddKey">Add new GPG key</gr-button>
</fieldset>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

4
polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.html
View File

@@ -57,7 +57,7 @@ limitations under the License.
</section>
<gr-button
id="generateButton"
on-tap="_handleGenerateTap">Generate new password</gr-button>
on-click="_handleGenerateTap">Generate new password</gr-button>
</div>
<span hidden$="[[!_passwordUrl]]">
<a href$="[[_passwordUrl]]" target="_blank" rel="noopener">
@@ -81,7 +81,7 @@ limitations under the License.
<gr-button
link
class="closeButton"
on-tap="_closeOverlay">Close</gr-button>
on-click="_closeOverlay">Close</gr-button>
</div>
</gr-overlay>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

2
polygerrit-ui/app/elements/settings/gr-identities/gr-identities.html
View File

@@ -75,7 +75,7 @@ limitations under the License.
<td class="deleteColumn">
<gr-button
class$="deleteButton [[_computeHideDeleteClass(item.can_delete)]]"
on-tap="_handleDeleteItem">
on-click="_handleDeleteItem">
Delete
</gr-button>
</td>

8
polygerrit-ui/app/elements/settings/gr-menu-editor/gr-menu-editor.html
View File

@@ -62,21 +62,21 @@ limitations under the License.
<gr-button
link
data-index="[[index]]"
on-tap="_handleMoveUpButton"
on-click="_handleMoveUpButton"
class="moveUpButton">↑</gr-button>
</td>
<td class="buttonColumn">
<gr-button
link
data-index="[[index]]"
on-tap="_handleMoveDownButton"
on-click="_handleMoveDownButton"
class="moveDownButton">↓</gr-button>
</td>
<td>
<gr-button
link
data-index="[[index]]"
on-tap="_handleDeleteButton"
on-click="_handleDeleteButton"
class="remove-button">Delete</gr-button>
</td>
</tr>
@@ -116,7 +116,7 @@ limitations under the License.
<gr-button
link
disabled$="[[_computeAddDisabled(_newName, _newUrl)]]"
on-tap="_handleAddButton">Add</gr-button>
on-click="_handleAddButton">Add</gr-button>
</th>
</tr>
</tfoot>

4
polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog.html
View File

@@ -127,13 +127,13 @@ limitations under the License.
id="closeButton"
link
disabled="[[_saving]]"
on-tap="_handleClose">Close</gr-button>
on-click="_handleClose">Close</gr-button>
<gr-button
id="saveButton"
primary
link
disabled="[[_computeSaveDisabled(_account.name, _account.email, _saving)]]"
on-tap="_handleSave">Save</gr-button>
on-click="_handleSave">Save</gr-button>
</footer>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

20
polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.html
View File

@@ -132,7 +132,7 @@ limitations under the License.
mutable="{{_accountNameMutable}}"
has-unsaved-changes="{{_accountInfoChanged}}"></gr-account-info>
<gr-button
on-tap="_handleSaveAccountInfo"
on-click="_handleSaveAccountInfo"
disabled="[[!_accountInfoChanged]]">Save changes</gr-button>
</fieldset>
<h2
@@ -278,7 +278,7 @@ limitations under the License.
</section>
<gr-button
id="savePrefs"
on-tap="_handleSavePreferences"
on-click="_handleSavePreferences"
disabled="[[!_prefsChanged]]">Save changes</gr-button>
</fieldset>
<h2
@@ -292,7 +292,7 @@ limitations under the License.
has-unsaved-changes="{{_diffPrefsChanged}}"></gr-diff-preferences>
<gr-button
id="saveDiffPrefs"
on-tap="_handleSaveDiffPreferences"
on-click="_handleSaveDiffPreferences"
disabled$="[[!_diffPrefsChanged]]">Save changes</gr-button>
</fieldset>
<h2
@@ -306,7 +306,7 @@ limitations under the License.
has-unsaved-changes="{{_editPrefsChanged}}"></gr-edit-preferences>
<gr-button
id="saveEditPrefs"
on-tap="_handleSaveEditPreferences"
on-click="_handleSaveEditPreferences"
disabled$="[[!_editPrefsChanged]]">Save changes</gr-button>
</fieldset>
<h2 id="Menu" class$="[[_computeHeaderClass(_menuChanged)]]">Menu</h2>
@@ -315,12 +315,12 @@ limitations under the License.
menu-items="{{_localMenu}}"></gr-menu-editor>
<gr-button
id="saveMenu"
on-tap="_handleSaveMenu"
on-click="_handleSaveMenu"
disabled="[[!_menuChanged]]">Save changes</gr-button>
<gr-button
id="resetMenu"
link
on-tap="_handleResetMenuButton">Reset</gr-button>
on-click="_handleResetMenuButton">Reset</gr-button>
</fieldset>
<h2 id="ChangeTableColumns"
class$="[[_computeHeaderClass(_changeTableChanged)]]">
@@ -333,7 +333,7 @@ limitations under the License.
</gr-change-table-editor>
<gr-button
id="saveChangeTable"
on-tap="_handleSaveChangeTable"
on-click="_handleSaveChangeTable"
disabled="[[!_changeTableChanged]]">Save changes</gr-button>
</fieldset>
<h2
@@ -346,7 +346,7 @@ limitations under the License.
has-unsaved-changes="{{_watchedProjectsChanged}}"
id="watchedProjectsEditor"></gr-watched-projects-editor>
<gr-button
on-tap="_handleSaveWatchedProjects"
on-click="_handleSaveWatchedProjects"
disabled$="[[!_watchedProjectsChanged]]"
id="_handleSaveWatchedProjects">Save changes</gr-button>
</fieldset>
@@ -360,7 +360,7 @@ limitations under the License.
id="emailEditor"
has-unsaved-changes="{{_emailsChanged}}"></gr-email-editor>
<gr-button
on-tap="_handleSaveEmails"
on-click="_handleSaveEmails"
disabled$="[[!_emailsChanged]]">Save changes</gr-button>
</fieldset>
<fieldset id="newEmail">
@@ -395,7 +395,7 @@ limitations under the License.
</section>
<gr-button
disabled="[[!_computeAddEmailButtonEnabled(_newEmail, _addingEmail)]]"
on-tap="_handleAddEmailButton">Send verification</gr-button>
on-click="_handleAddEmailButton">Send verification</gr-button>
</fieldset>
<template is="dom-if" if="[[_showHttpAuth(_serverConfig)]]">
<div>

10
polygerrit-ui/app/elements/settings/gr-ssh-editor/gr-ssh-editor.html
View File

@@ -75,7 +75,7 @@ limitations under the License.
<td>
<gr-button
link
on-tap="_showKey"
on-click="_showKey"
data-index$="[[index]]"
link>Click to View</gr-button>
</td>
@@ -83,7 +83,7 @@ limitations under the License.
<gr-button
link
data-index$="[[index]]"
on-tap="_handleDeleteKey">Delete</gr-button>
on-click="_handleDeleteKey">Delete</gr-button>
</td>
</tr>
</template>
@@ -106,10 +106,10 @@ limitations under the License.
</fieldset>
<gr-button
class="closeButton"
on-tap="_closeOverlay">Close</gr-button>
on-click="_closeOverlay">Close</gr-button>
</gr-overlay>
<gr-button
on-tap="save"
on-click="save"
disabled$="[[!hasUnsavedChanges]]">Save changes</gr-button>
</fieldset>
<fieldset>
@@ -127,7 +127,7 @@ limitations under the License.
id="addButton"
link
disabled$="[[_computeAddButtonDisabled(_newKey)]]"
on-tap="_handleAddKey">Add new SSH key</gr-button>
on-click="_handleAddKey">Add new SSH key</gr-button>
</fieldset>
</div>
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>

4
polygerrit-ui/app/elements/settings/gr-watched-projects-editor/gr-watched-projects-editor.html
View File

@@ -87,7 +87,7 @@ limitations under the License.
<gr-button
link
data-index$="[[projectIndex]]"
on-tap="_handleRemoveProject">Delete</gr-button>
on-click="_handleRemoveProject">Delete</gr-button>
</td>
</tr>
</template>
@@ -115,7 +115,7 @@ limitations under the License.
</iron-input>
</th>
<th>
<gr-button link on-tap="_handleAddProject">Add</gr-button>
<gr-button link on-click="_handleAddProject">Add</gr-button>
</th>
</tr>
</tfoot>

2
polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.html
View File

@@ -101,7 +101,7 @@ limitations under the License.
tabindex="-1"
aria-label="Remove"
class$="remove [[_getBackgroundClass(transparentBackground)]]"
on-tap="_handleRemoveTap">
on-click="_handleRemoveTap">
<iron-icon icon="gr-icons:close"></iron-icon>
</gr-button>
</div>

2
polygerrit-ui/app/elements/shared/gr-alert/gr-alert.html
View File

@@ -78,7 +78,7 @@ limitations under the License.
link
class="action"
hidden$="[[_hideActionButton]]"
on-tap="_handleActionTap">[[actionText]]</gr-button>
on-click="_handleActionTap">[[actionText]]</gr-button>
</div>
</template>
<script src="gr-alert.js"></script>

8
polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.html
View File

@@ -97,25 +97,25 @@ limitations under the License.
link
secondary
class="action reply"
on-tap="_handleCommentReply">Reply</gr-button>
on-click="_handleCommentReply">Reply</gr-button>
<gr-button
id="quoteBtn"
link
secondary
class="action quote"
on-tap="_handleCommentQuote">Quote</gr-button>
on-click="_handleCommentQuote">Quote</gr-button>
<gr-button
id="ackBtn"
link
secondary
class="action ack"
on-tap="_handleCommentAck">Ack</gr-button>
on-click="_handleCommentAck">Ack</gr-button>
<gr-button
id="doneBtn"
link
secondary
class="action done"
on-tap="_handleCommentDone">Done</gr-button>
on-click="_handleCommentDone">Done</gr-button>
</div>
</div>
</div>

12
polygerrit-ui/app/elements/shared/gr-comment/gr-comment.html
View File

@@ -262,7 +262,7 @@ limitations under the License.
link
secondary
class$="action delete [[_computeDeleteButtonClass(_isAdmin, draft)]]"
on-tap="_handleCommentDelete">
on-click="_handleCommentDelete">
(Delete)
</gr-button>
<span class="date" on-tap="_handleAnchorTap">
@@ -331,23 +331,23 @@ limitations under the License.
link
secondary
class="action cancel hideOnPublished"
on-tap="_handleCancel">Cancel</gr-button>
on-click="_handleCancel">Cancel</gr-button>
<gr-button
link
secondary
class="action discard hideOnPublished"
on-tap="_handleDiscard">Discard</gr-button>
on-click="_handleDiscard">Discard</gr-button>
<gr-button
link
secondary
class="action edit hideOnPublished"
on-tap="_handleEdit">Edit</gr-button>
on-click="_handleEdit">Edit</gr-button>
<gr-button
link
secondary
disabled$="[[_computeSaveDisabled(_messageText, comment, resolved)]]"
class="action save hideOnPublished"
on-tap="_handleSave">Save</gr-button>
on-click="_handleSave">Save</gr-button>
</div>
</div>
<div class="robotActions" hidden$="[[!_showRobotActions]]">
@@ -356,7 +356,7 @@ limitations under the License.
link
secondary
class="action fix"
on-tap="_handleFix"
on-click="_handleFix"
disabled="[[robotButtonDisabled]]">
Please Fix
</gr-button>

2
polygerrit-ui/app/elements/shared/gr-copy-clipboard/gr-copy-clipboard.html
View File

@@ -68,7 +68,7 @@ limitations under the License.
has-tooltip="[[hasTooltip]]"
class="copyToClipboard"
title="[[buttonTitle]]"
on-tap="_copyToClipboard">
on-click="_copyToClipboard">
<iron-icon id="icon" icon="gr-icons:content-copy"></iron-icon>
</gr-button>
</div>

4
polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.html
View File

@@ -64,10 +64,10 @@ limitations under the License.
<header><slot name="header"></slot></header>
<main><slot name="main"></slot></main>
<footer>
<gr-button id="cancel" class$="[[_computeCancelClass(cancelLabel)]]" link on-tap="_handleCancelTap">
<gr-button id="cancel" class$="[[_computeCancelClass(cancelLabel)]]" link on-click="_handleCancelTap">
[[cancelLabel]]
</gr-button>
<gr-button id="confirm" link primary on-tap="_handleConfirm" disabled="[[disabled]]">
<gr-button id="confirm" link primary on-click="_handleConfirm" disabled="[[disabled]]">
[[confirmLabel]]
</gr-button>
</footer>

2
polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.html
View File

@@ -140,7 +140,7 @@ limitations under the License.
link
id="trigger"
class="dropdown-trigger"
on-tap="_showDropdownTapHandler"
on-click="_showDropdownTapHandler"
slot="dropdown-trigger">
<span id="triggerText">[[text]]</span>
</gr-button>

2
polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.html
View File

@@ -101,7 +101,7 @@ limitations under the License.
link="[[link]]"
class="dropdown-trigger" id="trigger"
down-arrow="[[downArrow]]"
on-tap="_dropdownTriggerTapHandler">
on-click="_dropdownTriggerTapHandler">
<slot></slot>
</gr-button>
<iron-dropdown id="dropdown"

4
polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.html
View File

@@ -54,10 +54,10 @@ limitations under the License.
disabled="[[disabled]]"></iron-autogrow-textarea>
<div class="editButtons">
<gr-button primary
on-tap="_handleSave"
on-click="_handleSave"
disabled="[[_saveDisabled]]">Save</gr-button>
<gr-button
on-tap="_handleCancel"
on-click="_handleCancel"
disabled="[[disabled]]">Cancel</gr-button>
</div>
</div>

4
polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.html
View File

@@ -98,8 +98,8 @@ limitations under the License.
maxlength="[[maxLength]]"
value="{{_inputText}}"></paper-input>
<div class="buttons">
<gr-button link id="cancelBtn" on-tap="_cancel">cancel</gr-button>
<gr-button link id="saveBtn" on-tap="_save">save</gr-button>
<gr-button link id="cancelBtn" on-click="_cancel">cancel</gr-button>
<gr-button link id="saveBtn" on-click="_save">save</gr-button>
</div>
</div>
</div>

2
polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.html
View File

@@ -111,7 +111,7 @@ limitations under the License.
<gr-button
link
aria-label="Remove"
on-tap="_onDeleteVote"
on-click="_onDeleteVote"
tooltip="Remove vote"
data-account-id$="[[mappedLabel.account._account_id]]"
class$="deleteBtn [[_computeDeleteClass(mappedLabel.account, mutable, change)]]">

2
polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.html
View File

@@ -91,7 +91,7 @@ limitations under the License.
hidden$="[[!removable]]"
hidden
class$="remove [[_getBackgroundClass(transparentBackground)]]"
on-tap="_handleRemoveTap">
on-click="_handleRemoveTap">
<iron-icon icon="gr-icons:close"></iron-icon>
</gr-button>
</div>

2
polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.html
View File

@@ -82,7 +82,7 @@ limitations under the License.
</div>
<div id="createNewContainer"
class$="[[_computeCreateClass(createNew)]]">
<gr-button primary link id="createNew" on-tap="_createNewItem">
<gr-button primary link id="createNew" on-click="_createNewItem">
Create New
</gr-button>
</div>