opendev/gerrit
Code Issues Proposed changes

Allow inputting refs or commits for rebase

Browse Source 
The rebase dialog was updated recently with an autocomplete for change
numbers. Refs and commit hashes never appear in the autocomplete, thus
that change disabled the ability to rebase onto those types of entries.

This change adds an additional parameter to allow users to input values
other than the suggested change numbers, e.g. a ref.

Bug: Issue 8412
Change-Id: I90173641d0f0127abdb94edb994249851e4a2ca8
This commit is contained in:
Kasper Nilsson
2018-02-27 13:37:44 -08:00
parent 3e7efadda7
commit 695b756ef9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html
View File

@@ -95,7 +95,7 @@ limitations under the License.
type="radio"
on-tap="_handleRebaseOnOther">
<label id="rebaseOnOtherLabel" for="rebaseOnOtherInput">
Rebase on a specific change or ref <span hidden$="[[!hasParent]]">
Rebase on a specific change, ref, or commit <span hidden$="[[!hasParent]]">
(breaks relation chain)
</span>
</label>
@@ -107,7 +107,8 @@ limitations under the License.
text="{{_inputText}}"
on-tap="_handleEnterChangeNumberTap"
on-commit="_handleBaseSelected"
placeholder="Change number">
allow-non-suggested-values
placeholder="Change number, ref, or commit hash">
</gr-autocomplete>
</div>
</div>