opendev/gerrit
Code Issues Proposed changes

Use project lookup on change starring requests

Browse Source 
Change-Id: Iee8de3c68b3f78222a4ef63ba5de680a17033674
(cherry picked from commit f91e636ffb)
This commit is contained in:
Logan Hanks
2018-10-26 11:41:27 -07:00
committed by Paladox none
parent 7ebeab7f5b
commit 6cd6fad3e1
2 changed files with 34 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
View File

@@ -2086,10 +2086,17 @@
},
saveChangeStarred(changeNum, starred) {
return this._send({
method: starred ? 'PUT' : 'DELETE',
url: '/accounts/self/starred.changes/' + changeNum,
anonymizedUrl: '/accounts/self/starred.changes/*',
// Some servers may require the project name to be provided
// alongside the change number, so resolve the project name
// first.
return this.getFromProjectLookup(changeNum).then(project => {
const url = '/accounts/self/starred.changes/' +
(project ? encodeURIComponent(project) + '~' : '') + changeNum;
return this._send({
method: starred ? 'PUT' : 'DELETE',
url,
anonymizedUrl: '/accounts/self/starred.changes/*',
});
});
},

23
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html
View File

@@ -1446,5 +1446,28 @@ limitations under the License.
flushAsynchronousOperations();
assert.isTrue(handler.calledOnce);
});
test('saveChangeStarred', async () => {
sandbox.stub(element, 'getFromProjectLookup')
.returns(Promise.resolve('test'));
const sendStub =
sandbox.stub(element, '_send').returns(Promise.resolve());
await element.saveChangeStarred(123, true);
assert.isTrue(sendStub.calledOnce);
assert.deepEqual(sendStub.lastCall.args[0], {
method: 'PUT',
url: '/accounts/self/starred.changes/test~123',
anonymizedUrl: '/accounts/self/starred.changes/*',
});
await element.saveChangeStarred(456, false);
assert.isTrue(sendStub.calledTwice);
assert.deepEqual(sendStub.lastCall.args[0], {
method: 'DELETE',
url: '/accounts/self/starred.changes/test~456',
anonymizedUrl: '/accounts/self/starred.changes/*',
});
});
});
</script>