opendev/gerrit
Code Issues Proposed changes

{Account|Change|Group}IndexCollection: Remove unnecessary @Inject

Browse Source 
These classes don't have any injected arguments in their constructors,
so do not need to be annotated with @Inject.

Change-Id: I12b0a3f04d8d7cdba8c0e9f1e33406fcb6d00b10
This commit is contained in:
David Pursehouse
2017-08-25 10:38:56 +09:00
parent f93873fe7d
commit 7c754c1975
3 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/index/account/AccountIndexCollection.java
View File

@@ -18,13 +18,11 @@ import com.google.common.annotations.VisibleForTesting;
import com.google.gerrit.index.IndexCollection;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.server.account.AccountState;
import com.google.inject.Inject;
import com.google.inject.Singleton;
@Singleton
public class AccountIndexCollection
extends IndexCollection<Account.Id, AccountState, AccountIndex> {
@Inject
@VisibleForTesting
public AccountIndexCollection() {}
}

2
gerrit-server/src/main/java/com/google/gerrit/server/index/change/ChangeIndexCollection.java
View File

@@ -18,12 +18,10 @@ import com.google.common.annotations.VisibleForTesting;
import com.google.gerrit.index.IndexCollection;
import com.google.gerrit.reviewdb.client.Change;
import com.google.gerrit.server.query.change.ChangeData;
import com.google.inject.Inject;
import com.google.inject.Singleton;
@Singleton
public class ChangeIndexCollection extends IndexCollection<Change.Id, ChangeData, ChangeIndex> {
@Inject
@VisibleForTesting
public ChangeIndexCollection() {}
}

2
gerrit-server/src/main/java/com/google/gerrit/server/index/group/GroupIndexCollection.java
View File

@@ -17,13 +17,11 @@ package com.google.gerrit.server.index.group;
import com.google.common.annotations.VisibleForTesting;
import com.google.gerrit.index.IndexCollection;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.inject.Inject;
import com.google.inject.Singleton;
@Singleton
public class GroupIndexCollection
extends IndexCollection<AccountGroup.UUID, AccountGroup, GroupIndex> {
@Inject
@VisibleForTesting
public GroupIndexCollection() {}
}