Don’t show emails next to names in change view metadata

They still show up when hovering over the name, but given the
three-column layout, they simply take up too much space.

Change-Id: I98f32d07bd1e4d50fa624231769e5c9209e68302
This commit is contained in:
Andrew Bonventre
2016-02-16 12:45:33 -05:00
parent ad681e9d46
commit 7f8f5569b2
3 changed files with 4 additions and 14 deletions

View File

@@ -36,8 +36,7 @@ limitations under the License.
<span>
<a href$="[[_computeOwnerLink(account)]]">
<gr-account-label account="[[account]]"
avatar-image-size="[[avatarImageSize]]"
show-email="[[showEmail]]"></gr-account-label>
avatar-image-size="[[avatarImageSize]]"></gr-account-label>
</a>
</span>
</template>
@@ -54,10 +53,6 @@ limitations under the License.
type: Number,
value: 32,
},
showEmail: {
type: Boolean,
value: false,
},
},
_computeOwnerLink: function(account) {

View File

@@ -111,9 +111,6 @@ limitations under the License.
padding: 2px 5px 2px 0;
vertical-align: top;
}
gr-reviewer-list {
min-width: 25em;
}
.changeMetadata-label {
font-weight: bold;
}
@@ -221,8 +218,7 @@ limitations under the License.
<tr>
<td class="changeMetadata-label">Owner</td>
<td>
<gr-account-link account="[[_change.owner]]"
show-email></gr-account-link>
<gr-account-link account="[[_change.owner]]"></gr-account-link>
</td>
</tr>
<tr>
@@ -268,8 +264,7 @@ limitations under the License.
<div class="labelValue">
<span class$="[[label.className]]">
<span>[[label.value]]</span>
<gr-account-link account="[[label.account]]"
show-email></gr-account-link>
<gr-account-link account="[[label.account]]"></gr-account-link>
</span>
</div>
</template>

View File

@@ -76,7 +76,7 @@ limitations under the License.
<template is="dom-repeat" items="[[_reviewers]]" as="reviewer">
<div class="reviewer">
<gr-account-link account="[[reviewer]]" show-email></gr-account-link>
<gr-account-link account="[[reviewer]]"></gr-account-link>
<a class="remove"
href="#"
data-account-id$="[[reviewer._account_id]]"