opendev/gerrit
Code Issues Proposed changes

ListProjects: Fix operator precedence warning raised by ErrorProne

Browse Source 
Add grouping parenthesis to make the operator precedence explicit.

See http://errorprone.info/bugpattern/OperatorPrecedence

Change-Id: I8a0853f8fac05218e77e1a94ebff989380246d37
This commit is contained in:
David Pursehouse
2018-09-06 17:36:36 +09:00
parent 1e7d62cdcc
commit 8cf9a823ea
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java
View File

@@ -524,9 +524,9 @@ public class ListProjects implements RestReadView<TopLevelResource> {
try (Repository git = repoManager.openRepository(projectName)) {
for (int i = 0; i < showBranch.size(); i++) {
Ref ref = git.findRef(showBranch.get(i));
if (ref != null
if ((ref != null
&& ref.getObjectId() != null
&& (projectControl.controlForRef(ref.getLeaf().getName()).isVisible())
&& (projectControl.controlForRef(ref.getLeaf().getName()).isVisible()))
|| (all && projectControl.isOwner())) {
result[i] = ref;
}