opendev/gerrit
Code Issues Proposed changes

Buck: Fix typo in gerrit_plugin.bucklet

Browse Source 
Typo that was introduced in Ia6cf1bad wasn't discovered for years.
When plugin is trying to add classpath rule:

  java_library(
    name = 'classpath',
    deps = GERRIT_GWT_API + GERRIT_PLUGIN_API + [
      ':<plugin>__plugin',
    ],
  )

then Buck is reporting non-existing rule. Note that in bucklets
the correct constant is defined:

  GERRIT_GWT_API = ['//lib/gerrit:gwtui-api']

Change-Id: Ice8418d27b08a8ee7925a4040c3a18ce5cd553f2
This commit is contained in:
David Ostrovsky
2015-12-23 17:51:42 +01:00
committed by David Pursehouse
parent 80476a51df
commit 8d794c4776
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bucklets/gerrit_plugin.bucklet
View File

@@ -14,7 +14,7 @@
# When compiling from standalone cookbook-plugin, bucklets directory points
# to cloned bucklets library that includes real gerrit_plugin.bucklet code.
GERRIT_GWT_API = ['//gerrit-plugin-gwtui/gerrit:gwtui-api']
GERRIT_GWT_API = ['//gerrit-plugin-gwtui:gwtui-api']
GERRIT_PLUGIN_API = ['//gerrit-plugin-api:lib']
GERRIT_TESTS = ['//gerrit-acceptance-framework:lib']