opendev/gerrit
Code Issues Proposed changes

Replace deprecated Accessibility class with Roles from GWT ARIA

Browse Source 
The Accessibility class is deprecated.  Use the Roles factory
class from the GWT ARIA library instead.

Change-Id: I8bf6fd0ad30c6df9e13ae9b459933ec41a79b080
This commit is contained in:
David Pursehouse
2012-11-19 19:36:00 +09:00
parent aaaa6d35a2
commit 92e7406a96
8 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java
View File

@@ -42,6 +42,7 @@ import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.AccountDiffPreference;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
import com.google.gerrit.reviewdb.client.AuthType;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.core.client.Callback;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.GWT;
@@ -58,7 +59,6 @@ import com.google.gwt.user.client.Cookies;
import com.google.gwt.user.client.History;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.Window.Location;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Grid;
@@ -769,7 +769,7 @@ public class Gerrit implements EntryPoint {
private static Anchor anchor(final String text, final String to) {
final Anchor a = new Anchor(text, to);
a.setStyleName(RESOURCES.css().menuItem());
Accessibility.setRole(a.getElement(), Accessibility.ROLE_MENUITEM);
Roles.getMenuitemRole().set(a.getElement());
return a;
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandLink.java
View File

@@ -16,10 +16,10 @@ package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.Widget;
import com.google.gwtjsonrpc.common.VoidResult;
@@ -32,7 +32,7 @@ abstract class DownloadCommandLink extends Anchor implements ClickHandler {
super(text);
this.cmdType = cmdType;
setStyleName(Gerrit.RESOURCES.css().downloadLink());
Accessibility.setRole(getElement(), Accessibility.ROLE_TAB);
Roles.getTabRole().set(getElement());
addClickHandler(this);
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadCommandPanel.java
View File

@@ -17,7 +17,7 @@ package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences.DownloadCommand;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Widget;
@@ -27,7 +27,7 @@ class DownloadCommandPanel extends FlowPanel {
DownloadCommandPanel() {
setStyleName(Gerrit.RESOURCES.css().downloadLinkList());
Accessibility.setRole(getElement(), Accessibility.ROLE_TABLIST);
Roles.getTablistRole().set(getElement());
}
boolean isEmpty() {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlLink.java
View File

@@ -16,10 +16,10 @@ package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwtjsonrpc.common.AsyncCallback;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.Widget;
import com.google.gwtjsonrpc.common.VoidResult;
@@ -34,7 +34,7 @@ class DownloadUrlLink extends Anchor implements ClickHandler {
this.urlType = urlType;
this.urlData = urlData;
setStyleName(Gerrit.RESOURCES.css().downloadLink());
Accessibility.setRole(getElement(), Accessibility.ROLE_TAB);
Roles.getTabRole().set(getElement());
addClickHandler(this);
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/DownloadUrlPanel.java
View File

@@ -16,7 +16,7 @@ package com.google.gerrit.client.changes;
import com.google.gerrit.client.Gerrit;
import com.google.gerrit.reviewdb.client.AccountGeneralPreferences;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Widget;
@@ -26,7 +26,7 @@ class DownloadUrlPanel extends FlowPanel {
DownloadUrlPanel(final DownloadCommandPanel commandPanel) {
this.commandPanel = commandPanel;
setStyleName(Gerrit.RESOURCES.css().downloadLinkList());
Accessibility.setRole(getElement(), Accessibility.ROLE_TABLIST);
Roles.getTablistRole().set(getElement());
}
boolean isEmpty() {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommandMenuItem.java
View File

@@ -15,10 +15,10 @@
package com.google.gerrit.client.ui;
import com.google.gerrit.client.Gerrit;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.user.client.ui.Anchor;
public class CommandMenuItem extends Anchor implements ClickHandler {
@@ -27,7 +27,7 @@ public class CommandMenuItem extends Anchor implements ClickHandler {
public CommandMenuItem(final String text, final Command cmd) {
super(text);
setStyleName(Gerrit.RESOURCES.css().menuItem());
Accessibility.setRole(getElement(), Accessibility.ROLE_MENUITEM);
Roles.getMenuitemRole().set(getElement());
addClickHandler(this);
command = cmd;
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/LinkMenuBar.java
View File

@@ -15,8 +15,8 @@
package com.google.gerrit.client.ui;
import com.google.gerrit.client.Gerrit;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.ui.Accessibility;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Widget;
@@ -28,7 +28,7 @@ public class LinkMenuBar extends Composite {
body = new FlowPanel();
initWidget(body);
setStyleName(Gerrit.RESOURCES.css().linkMenuBar());
Accessibility.setRole(getElement(), Accessibility.ROLE_MENUBAR);
Roles.getMenubarRole().set(getElement());
}
public void addItem(final String text, final Command imp) {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/LinkMenuItem.java
View File

@@ -15,14 +15,14 @@
package com.google.gerrit.client.ui;
import com.google.gerrit.client.Gerrit;
import com.google.gwt.aria.client.Roles;
import com.google.gwt.dom.client.AnchorElement;
import com.google.gwt.user.client.ui.Accessibility;
public class LinkMenuItem extends InlineHyperlink {
public LinkMenuItem(final String text, final String targetHistoryToken) {
super(text, targetHistoryToken);
setStyleName(Gerrit.RESOURCES.css().menuItem());
Accessibility.setRole(getElement(), Accessibility.ROLE_MENUITEM);
Roles.getMenuitemRole().set(getElement());
}
@Override