Clarify arguments to EmailReviewComments.Factory

Change-Id: I6c280739d24e23c7af45954c14e73036ae9020f7
This commit is contained in:
Dave Borowitz
2017-04-28 12:32:26 -04:00
parent 7cd9041726
commit 94fe07a4da

View File

@@ -50,6 +50,24 @@ public class EmailReviewComments implements Runnable, RequestContext {
private static final Logger log = LoggerFactory.getLogger(EmailReviewComments.class);
public interface Factory {
// TODO(dborowitz/wyatta): Rationalize these arguments so HTML and text templates are operating
// on the same set of inputs.
/**
* @param notify setting for handling notification.
* @param accountsToNotify detailed map of accounts to notify.
* @param notes change notes.
* @param patchSet patch set corresponding to the top-level op
* @param user user the email should come from.
* @param message used by text template only: the full ChangeMessage that will go in the
* database. The contents of this message typically include the "Patch set N" header and "(M
* comments)".
* @param comments inline comments.
* @param patchSetComment used by HTML template only: some quasi-human-generated text. The
* contents should *not* include a "Patch set N" header or "(M comments)" footer, as these
* will be added automatically in soy in a structured way.
* @param labels labels applied as part of this review operation.
* @return handle for sending email.
*/
EmailReviewComments create(
NotifyHandling notify,
ListMultimap<RecipientType, Account.Id> accountsToNotify,