Invert signed-in and signed-out background colors
Most users work in the signed-in mode when reading source files during review. Using the white background makes it easier to read the text, especially with syntax coloring enabled. Change-Id: If49aa62c0ff26971c64fd75505265c58ac859062 Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
parent
79f88a11e8
commit
9ca8ae3eca
|
@ -1795,8 +1795,8 @@ Background color for the page, and major data tables like the all
|
||||||
open changes table or the account dashboard. The value must be a
|
open changes table or the account dashboard. The value must be a
|
||||||
valid HTML hex color code, or standard color name.
|
valid HTML hex color code, or standard color name.
|
||||||
+
|
+
|
||||||
By default white, `FFFFFF` for signed-out theme and `FCFEEF` (creme)
|
By default `FCFEEF` (a creme color) for signed-out theme and white
|
||||||
for signed-in theme.
|
(`FFFFFF`) for signed-in theme.
|
||||||
|
|
||||||
[[theme.topMenuColor]]theme.topMenuColor::
|
[[theme.topMenuColor]]theme.topMenuColor::
|
||||||
+
|
+
|
||||||
|
|
|
@ -38,7 +38,7 @@ class ThemeFactory {
|
||||||
|
|
||||||
private HostPageData.Theme getTheme(String name) {
|
private HostPageData.Theme getTheme(String name) {
|
||||||
HostPageData.Theme theme = new HostPageData.Theme();
|
HostPageData.Theme theme = new HostPageData.Theme();
|
||||||
theme.backgroundColor = color(name, "backgroundColor", "#FFFFFF");
|
theme.backgroundColor = color(name, "backgroundColor", "#FCFEEF");
|
||||||
theme.textColor = color(name, "textColor", "#000000");
|
theme.textColor = color(name, "textColor", "#000000");
|
||||||
theme.trimColor = color(name, "trimColor", "#D4E9A9");
|
theme.trimColor = color(name, "trimColor", "#D4E9A9");
|
||||||
theme.selectionColor = color(name, "selectionColor", "#FFFFCC");
|
theme.selectionColor = color(name, "selectionColor", "#FFFFCC");
|
||||||
|
@ -52,7 +52,7 @@ class ThemeFactory {
|
||||||
v = cfg.getString("theme", null, name);
|
v = cfg.getString("theme", null, name);
|
||||||
if (v == null || v.isEmpty()) {
|
if (v == null || v.isEmpty()) {
|
||||||
if ("signed-in".equals(section) && "backgroundColor".equals(name)) {
|
if ("signed-in".equals(section) && "backgroundColor".equals(name)) {
|
||||||
v = "#FCFEEF";
|
v = "#FFFFFF";
|
||||||
} else {
|
} else {
|
||||||
v = defaultValue;
|
v = defaultValue;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue