Use default value in undefined check if provided
Change-Id: Icff2a8b17e4f8be50c1af462def4140140533feb
This commit is contained in:
@@ -1048,7 +1048,7 @@
|
||||
_computeReplyButtonLabel(changeRecord, canStartReview) {
|
||||
// Polymer 2: check for undefined
|
||||
if ([changeRecord, canStartReview].some(arg => arg === undefined)) {
|
||||
return undefined;
|
||||
return 'Reply';
|
||||
}
|
||||
|
||||
if (canStartReview) {
|
||||
|
||||
@@ -159,7 +159,7 @@
|
||||
_computeSchemes(change, patchNum) {
|
||||
// Polymer 2: check for undefined
|
||||
if ([change, patchNum].some(arg => arg === undefined)) {
|
||||
return undefined;
|
||||
return [];
|
||||
}
|
||||
|
||||
for (const rev of Object.values(change.revisions || {})) {
|
||||
|
||||
@@ -216,7 +216,7 @@
|
||||
newContent,
|
||||
saving,
|
||||
].some(arg => arg === undefined)) {
|
||||
return undefined;
|
||||
return true;
|
||||
}
|
||||
|
||||
if (saving) {
|
||||
|
||||
@@ -124,7 +124,7 @@
|
||||
content,
|
||||
newContent,
|
||||
].some(arg => arg === undefined)) {
|
||||
return undefined;
|
||||
return true;
|
||||
}
|
||||
|
||||
return disabled || (content === newContent);
|
||||
|
||||
Reference in New Issue
Block a user