opendev/gerrit
Code Issues Proposed changes

Use default value in undefined check if provided

Browse Source 
Change-Id: Icff2a8b17e4f8be50c1af462def4140140533feb
This commit is contained in:
Tao Zhou
2019-08-13 15:56:32 +02:00
parent 1d7ac477d8
commit 9e310e1612
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@@ -1048,7 +1048,7 @@
_computeReplyButtonLabel(changeRecord, canStartReview) { _computeReplyButtonLabel(changeRecord, canStartReview) {
// Polymer 2: check for undefined // Polymer 2: check for undefined
if ([changeRecord, canStartReview].some(arg => arg === undefined)) { if ([changeRecord, canStartReview].some(arg => arg === undefined)) {
return undefined; return 'Reply';
} }
if (canStartReview) { if (canStartReview) {

2
polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js
View File

@@ -159,7 +159,7 @@
_computeSchemes(change, patchNum) { _computeSchemes(change, patchNum) {
// Polymer 2: check for undefined // Polymer 2: check for undefined
if ([change, patchNum].some(arg => arg === undefined)) { if ([change, patchNum].some(arg => arg === undefined)) {
return undefined; return [];
} }
for (const rev of Object.values(change.revisions || {})) { for (const rev of Object.values(change.revisions || {})) {

2
polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js
View File

@@ -216,7 +216,7 @@
newContent, newContent,
saving, saving,
].some(arg => arg === undefined)) { ].some(arg => arg === undefined)) {
return undefined; return true;
} }
if (saving) { if (saving) {

2
polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js
View File

@@ -124,7 +124,7 @@
content, content,
newContent, newContent,
].some(arg => arg === undefined)) { ].some(arg => arg === undefined)) {
return undefined; return true;
} }
return disabled || (content === newContent); return disabled || (content === newContent);