Use default value in undefined check if provided

Change-Id: Icff2a8b17e4f8be50c1af462def4140140533feb
This commit is contained in:
Tao Zhou
2019-08-13 15:56:32 +02:00
parent 1d7ac477d8
commit 9e310e1612
4 changed files with 4 additions and 4 deletions

View File

@@ -1048,7 +1048,7 @@
_computeReplyButtonLabel(changeRecord, canStartReview) {
// Polymer 2: check for undefined
if ([changeRecord, canStartReview].some(arg => arg === undefined)) {
return undefined;
return 'Reply';
}
if (canStartReview) {

View File

@@ -159,7 +159,7 @@
_computeSchemes(change, patchNum) {
// Polymer 2: check for undefined
if ([change, patchNum].some(arg => arg === undefined)) {
return undefined;
return [];
}
for (const rev of Object.values(change.revisions || {})) {

View File

@@ -216,7 +216,7 @@
newContent,
saving,
].some(arg => arg === undefined)) {
return undefined;
return true;
}
if (saving) {

View File

@@ -124,7 +124,7 @@
content,
newContent,
].some(arg => arg === undefined)) {
return undefined;
return true;
}
return disabled || (content === newContent);