Disable peer IP in reflog record per default

Bug: Issue 10810
Change-Id: Ia7a04cdce0425989059b92131afd8c2f6030d10b

Documentation/config-gerrit.txt

@@ -2300,7 +2300,7 @@ should set this to the URL of their issue tracker, if necessary.
 
 Record actual peer IP address in ref log entry for identified user.
 
-Defaults to true.
+Defaults to false.
 
 [[gerrit.secureStoreClass]]gerrit.secureStoreClass::
 +

java/com/google/gerrit/server/config/EnablePeerIPInReflogRecordProvider.java

@@ -24,7 +24,7 @@ public class EnablePeerIPInReflogRecordProvider implements Provider<Boolean> {
   @Inject
   EnablePeerIPInReflogRecordProvider(@GerritServerConfig Config config) {
     enablePeerIPInReflogRecord =
-        config.getBoolean("gerrit", null, "enablePeerIPInReflogRecord", true);
+        config.getBoolean("gerrit", null, "enablePeerIPInReflogRecord", false);
   }
 
   @Override

javatests/com/google/gerrit/acceptance/server/project/ReflogIT.java

@@ -66,6 +66,7 @@ public class ReflogIT extends AbstractDaemonTest {
   }
 
   @Test
+  @GerritConfig(name = "gerrit.enablePeerIPInReflogRecord", value = "true")
   public void peerIPIncludedInReflogRecord() throws Exception {
     PushOneCommit.Result r = createChange();
     Change.Id id = r.getChange().getId();
@@ -85,7 +86,6 @@ public class ReflogIT extends AbstractDaemonTest {
   }
 
   @Test
-  @GerritConfig(name = "gerrit.enablePeerIPInReflogRecord", value = "false")
   public void emaiIncludedInReflogRecord() throws Exception {
     PushOneCommit.Result r = createChange();
     Change.Id id = r.getChange().getId();

javatests/com/google/gerrit/server/IdentifiedUserTest.java

@@ -81,7 +81,7 @@ public class IdentifiedUserTest {
           protected void configure() {
             bind(Boolean.class)
                 .annotatedWith(EnablePeerIPInReflogRecord.class)
-                .toInstance(Boolean.TRUE);
+                .toInstance(Boolean.FALSE);
             bind(Config.class).annotatedWith(GerritServerConfig.class).toInstance(config);
             bind(String.class)
                 .annotatedWith(AnonymousCowardName.class)

javatests/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java

@@ -154,7 +154,7 @@ public abstract class AbstractChangeNotesTest {
                     .toInstance("http://localhost:8080/");
                 bind(Boolean.class)
                     .annotatedWith(EnablePeerIPInReflogRecord.class)
-                    .toInstance(Boolean.TRUE);
+                    .toInstance(Boolean.FALSE);
                 bind(Realm.class).to(FakeRealm.class);
                 bind(GroupBackend.class).to(SystemGroupBackend.class).in(SINGLETON);
                 bind(AccountCache.class).toInstance(accountCache);