opendev/gerrit
Code Issues Proposed changes

Cleanup display of branches panel when gitweb isn't configured

Browse Source 
The 4th column to show the gitweb link is pointless if there is
no gitweb configuration available for this server.  Skip it in
the table.

Change-Id: I59e8fd9233edbd73b61684f558a07c00bbc1b18b
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-02-26 17:32:23 -08:00
parent 76d86bb782
commit 9f54bc41b7
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesPanel.java
View File

@@ -248,7 +248,9 @@ public class ProjectBranchesPanel extends Composite {
fmt.addStyleName(0, 1, Gerrit.RESOURCES.css().iconHeader());
fmt.addStyleName(0, 2, Gerrit.RESOURCES.css().dataHeader());
fmt.addStyleName(0, 3, Gerrit.RESOURCES.css().dataHeader());
fmt.addStyleName(0, 4, Gerrit.RESOURCES.css().dataHeader());
if (Gerrit.getConfig().getGitwebLink() != null) {
fmt.addStyleName(0, 4, Gerrit.RESOURCES.css().dataHeader());
}
}
void deleteChecked() {
@@ -299,6 +301,8 @@ public class ProjectBranchesPanel extends Composite {
if (k.getRevision() != null) {
table.setText(row, 3, k.getRevision().get());
} else {
table.setText(row, 3, "");
}
if (c != null) {
@@ -310,7 +314,9 @@ public class ProjectBranchesPanel extends Composite {
fmt.addStyleName(row, 1, Gerrit.RESOURCES.css().iconCell());
fmt.addStyleName(row, 2, Gerrit.RESOURCES.css().dataCell());
fmt.addStyleName(row, 3, Gerrit.RESOURCES.css().dataCell());
fmt.addStyleName(row, 4, Gerrit.RESOURCES.css().dataCell());
if (c != null) {
fmt.addStyleName(row, 4, Gerrit.RESOURCES.css().dataCell());
}
setRowItem(row, k);
}