opendev/gerrit
Code Issues Proposed changes

Fix: 'Download' icons on diff UI cannot work correctly

Browse Source 
On SideBySide diff UI the 'Download' icon of the right version
does not work when the left version is not 'Base', get the left
version even if clicking on the right icon; 'Download' icon of
the left version always gets to be the 'Base' version, even if not
comparing with 'Base' at the left side. These bugs can also be
found on Unified UI.

Fixed.

Change-Id: I903d03460d4eff54ab1e92e4025b4414f8d33413
This commit is contained in:
Bruce Zu
2013-03-26 14:15:28 +08:00
committed by Shawn Pearce
parent faaedb9e14
commit a007b92c31
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchSetSelectBox.java
View File

@@ -190,10 +190,10 @@ public class PatchSetSelectBox extends Composite {
return null;
}
Patch.Key key =
(idSideA == null) ? patchKey : (new Patch.Key(idSideA, patchKey.get()));
Patch.Key key = (idActive == null) ? //
patchKey : (new Patch.Key(idActive, patchKey.get()));
String sideURL = (side == Side.A) ? "1" : "0";
String sideURL = (idActive == null) ? "1" : "0";
final String base = GWT.getHostPageBaseURL() + "cat/";
Image image = new Image(Gerrit.RESOURCES.downloadIcon());