Deprecate TrackingIdAccess.byTrackingId

This code path should only be used by the SQL indexing system, which
is being quickly deprecated in 2.8 and will be removed in 2.9 when
secondary indexing becomes the standard.

Change-Id: I6cd38e458767d839f4510de20ff0d1f81a254e12

gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/TrackingIdAccess.java

@@ -29,6 +29,7 @@ public interface TrackingIdAccess extends Access<TrackingId, TrackingId.Key> {
   @Query("WHERE key.changeId = ?")
   ResultSet<TrackingId> byChange(Change.Id change) throws OrmException;
 
+  @Deprecated
   @Query("WHERE key.trackingKey = ?")
   ResultSet<TrackingId> byTrackingId(TrackingId.Id trackingId)
       throws OrmException;

gerrit-server/src/main/java/com/google/gerrit/server/query/change/TrackingIdPredicate.java

@@ -46,6 +46,7 @@ class TrackingIdPredicate extends IndexPredicate<ChangeData> implements
     return false;
   }
 
+  @SuppressWarnings("deprecation")
   @Override
   public ResultSet<ChangeData> read() throws OrmException {
     HashSet<Change.Id> ids = new HashSet<Change.Id>();