opendev/gerrit
Code Issues Proposed changes

Deprecate TrackingIdAccess.byTrackingId

Browse Source 
This code path should only be used by the SQL indexing system, which
is being quickly deprecated in 2.8 and will be removed in 2.9 when
secondary indexing becomes the standard.

Change-Id: I6cd38e458767d839f4510de20ff0d1f81a254e12
This commit is contained in:
Shawn Pearce
2013-10-07 19:17:37 -07:00
parent 29de0bc846
commit a0976f51df
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/server/TrackingIdAccess.java
View File

@@ -29,6 +29,7 @@ public interface TrackingIdAccess extends Access<TrackingId, TrackingId.Key> {
@Query("WHERE key.changeId = ?") @Query("WHERE key.changeId = ?")
ResultSet<TrackingId> byChange(Change.Id change) throws OrmException; ResultSet<TrackingId> byChange(Change.Id change) throws OrmException;
@Deprecated
@Query("WHERE key.trackingKey = ?") @Query("WHERE key.trackingKey = ?")
ResultSet<TrackingId> byTrackingId(TrackingId.Id trackingId) ResultSet<TrackingId> byTrackingId(TrackingId.Id trackingId)
throws OrmException; throws OrmException;

1
gerrit-server/src/main/java/com/google/gerrit/server/query/change/TrackingIdPredicate.java
View File

@@ -46,6 +46,7 @@ class TrackingIdPredicate extends IndexPredicate<ChangeData> implements
return false; return false;
} }
@SuppressWarnings("deprecation")
@Override @Override
public ResultSet<ChangeData> read() throws OrmException { public ResultSet<ChangeData> read() throws OrmException {
HashSet<Change.Id> ids = new HashSet<Change.Id>(); HashSet<Change.Id> ids = new HashSet<Change.Id>();