opendev/gerrit
Code Issues Proposed changes

Move NPM version definitions into separate .bzl file in /lib

Browse Source 
Move the definitions of NPM_VERSIONS and NPM_SHA1S into a separate .bzl
file in the /lib folder so that upgrades to the NPM components (bower,
crisper, vulcanize) require the Library-Compliance label to be set.

Change-Id: I691bb4fbdeeba2f1b05753310a8673febbfb6786
This commit is contained in:
David Pursehouse
2017-10-19 09:54:07 +09:00
parent 709989f361
commit a0b711fd3c
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/js/npm.bzl Normal file
View File

@@ -0,0 +1,11 @@
NPM_VERSIONS = {
"bower": "1.8.2",
"crisper": "2.0.2",
"vulcanize": "1.14.8",
}
NPM_SHA1S = {
"bower": "adf53529c8d4af02ef24fb8d5341c1419d33e2f7",
"crisper": "7183c58cea33632fb036c91cefd1b43e390d22a2",
"vulcanize": "679107f251c19ab7539529b1e3fdd40829e6fc63",
}

12
tools/bzl/js.bzl
View File

@@ -2,17 +2,7 @@ NPMJS = "NPMJS"
GERRIT = "GERRIT:"
NPM_VERSIONS = {
"bower": "1.8.2",
"crisper": "2.0.2",
"vulcanize": "1.14.8",
}
NPM_SHA1S = {
"bower": "adf53529c8d4af02ef24fb8d5341c1419d33e2f7",
"crisper": "7183c58cea33632fb036c91cefd1b43e390d22a2",
"vulcanize": "679107f251c19ab7539529b1e3fdd40829e6fc63",
}
load("//lib/js:npm.bzl", "NPM_VERSIONS", "NPM_SHA1S")
def _npm_tarball(name):
return "%s@%s.npm_binary.tgz" % (name, NPM_VERSIONS[name])