opendev/gerrit
Code Issues Proposed changes

BatchUpdateTest: Extend GerritBaseTests

Browse Source 
GerritBaseTests sets up the logging configuration, so when the test
does not derive from that the logging does not work as expected.

There are probably some more unit tests that suffer the same problem
but I have not explicitly looked for them.

Change-Id: I16e3c91a7908923ab5d34dfda6b7964c96bbf16a
This commit is contained in:
David Pursehouse
2020-05-01 14:58:25 +09:00
parent d623a5c6e1
commit a0f6acfd08
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javatests/com/google/gerrit/server/update/BatchUpdateTest.java
View File

@@ -21,6 +21,7 @@ import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.gerrit.server.util.time.TimeUtil;
import com.google.gerrit.testing.GerritBaseTests;
import com.google.gerrit.testing.InMemoryTestEnvironment;
import com.google.inject.Inject;
import com.google.inject.Provider;
@@ -31,7 +32,7 @@ import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
public class BatchUpdateTest {
public class BatchUpdateTest extends GerritBaseTests {
@Rule public InMemoryTestEnvironment testEnvironment = new InMemoryTestEnvironment();
@Inject private GitRepositoryManager repoManager;