Merge "Prevent save while disabled"

This commit is contained in:
Wyatt Allen
2017-10-25 16:44:49 +00:00
committed by Gerrit Code Review
2 changed files with 21 additions and 0 deletions

View File

@@ -390,6 +390,10 @@
_handleSave(e) {
e.preventDefault();
// Ignore saves started while already saving.
if (this.disabled) { return; }
this.set('comment.__editing', false);
this.save();
},

View File

@@ -606,6 +606,23 @@ limitations under the License.
});
});
test('draft prevent save when disabled', () => {
const saveStub = sandbox.stub(element, 'save');
element.draft = true;
MockInteractions.tap(element.$$('.edit'));
element._messageText = 'good news, everyone!';
element.flushDebouncer('fire-update');
element.flushDebouncer('store');
element.disabled = true;
MockInteractions.tap(element.$$('.save'));
assert.isFalse(saveStub.called);
element.disabled = false;
MockInteractions.tap(element.$$('.save'));
assert.isTrue(saveStub.calledOnce);
});
test('clicking on date link does not trigger nav', () => {
const showStub = sinon.stub(page, 'show');
const dateEl = element.$$('.date');