opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Do not leak CSS to rest of application

Browse Source 
The button:disabled style here was leaking into the other application
panels, such as the Admin screens or the user settings screen after
ChangeScreen2 was viewed once in the current tab.

Protect the CSS selector using style names that appear only in the
ChangeScreen2 context, preventing the rule from matching other buttons
within the application.

Change-Id: If3cd46a9e067112632789aa327ebe508da882fe0
This commit is contained in:
Shawn Pearce
2013-09-29 22:51:15 -07:00
parent b5e1dd41e5
commit a62cd4cf4e
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen2.ui.xml
View File

@@ -27,11 +27,6 @@ limitations under the License.
@def INFO_WIDTH 450px;
@def HEADER_HEIGHT 29px;
button:disabled {
background-color: #999;
background-image: -webkit-linear-gradient(top, #999, #999);
}
.headerLine {
position: relative;
background-color: trimColor;
@@ -113,6 +108,12 @@ limitations under the License.
.popdown button.selected {
font-weight: bold;
}
.headerLine button:disabled,
.headerTable button:disabled,
.popdown button:disabled {
background-color: #999;
background-image: -webkit-linear-gradient(top, #999, #999);
}
.headerTable {
border-spacing: 0;

7
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/common.css
View File

@@ -42,6 +42,13 @@
-webkit-box-sizing: content-box;
}
.button:disabled,
.popup button:disabled,
.popup input[type='button']:disabled {
background-color: #999;
background-image: -webkit-linear-gradient(top, #999, #999);
}
.button div, .popup button div {
width: 54px;
white-space: nowrap;