opendev/gerrit
Code Issues Proposed changes

Add change topic in hook arguments

Browse Source 
It is not possible for hook scripts to include topic-specific
behaviour because the topic name is not included in the
arguments.

Add the topic as an argument in all relevant hooks.

Change-Id: Ib8b4703c851e97c32c08195ca27f3269742ec9e5
This commit is contained in:
David Pursehouse
2012-09-18 10:07:31 +09:00
committed by Gustaf Lundh
parent 4606d62a81
commit a80e3f9037
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Documentation/config-hooks.txt
View File

@@ -27,7 +27,7 @@ This is called whenever a patchset is created (this includes new
changes and drafts).
====
patchset-created --change <change id> --change-url <change url> --project <project name> --branch <branch> --uploader <uploader> --commit <sha1> --patchset <patchset id>
patchset-created --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --uploader <uploader> --commit <sha1> --patchset <patchset id>
====
draft-published
@@ -36,7 +36,7 @@ draft-published
This is called whenever a draft change is published.
====
draft-published --change <change id> --change-url <change url> --project <project name> --branch <branch> --uploader <uploader> --commit <sha1> --patchset <patchset id>
draft-published --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --uploader <uploader> --commit <sha1> --patchset <patchset id>
====
comment-added
@@ -45,7 +45,7 @@ comment-added
This is called whenever a comment is added to a change.
====
comment-added --change <change id> --change-url <change url> --project <project name> --branch <branch> --author <comment author> --commit <commit> --comment <comment> [--<approval category id> <score> --<approval category id> <score> ...]
comment-added --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --author <comment author> --commit <commit> --comment <comment> [--<approval category id> <score> --<approval category id> <score> ...]
====
change-merged
@@ -54,7 +54,7 @@ change-merged
Called whenever a change has been merged.
====
change-merged --change <change id> --change-url <change url> --project <project name> --branch <branch> --submitter <submitter> --commit <sha1>
change-merged --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --submitter <submitter> --commit <sha1>
====
change-abandoned
@@ -63,7 +63,7 @@ change-abandoned
Called whenever a change has been abandoned.
====
change-abandoned --change <change id> --change-url <change url> --project <project name> --branch <branch> --abandoner <abandoner> --reason <reason>
change-abandoned --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --abandoner <abandoner> --reason <reason>
====
change-restored
@@ -72,7 +72,7 @@ change-restored
Called whenever a change has been restored.
====
change-restored --change <change id> --change-url <change url> --project <project name> --branch <branch> --restorer <restorer> --reason <reason>
change-restored --change <change id> --change-url <change url> --project <project name> --branch <branch> --topic <topic> --restorer <restorer> --reason <reason>
====
ref-updated

6
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java
View File

@@ -235,6 +235,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--uploader", getDisplayName(uploader.getAccount()));
addArg(args, "--commit", event.patchSet.revision);
addArg(args, "--patchset", event.patchSet.number);
@@ -257,6 +258,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--uploader", getDisplayName(uploader.getAccount()));
addArg(args, "--commit", event.patchSet.revision);
addArg(args, "--patchset", event.patchSet.number);
@@ -289,6 +291,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--author", getDisplayName(account));
addArg(args, "--commit", event.patchSet.revision);
addArg(args, "--comment", comment == null ? "" : comment);
@@ -313,6 +316,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--submitter", getDisplayName(account));
addArg(args, "--commit", event.patchSet.revision);
@@ -333,6 +337,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--abandoner", getDisplayName(account));
addArg(args, "--reason", reason == null ? "" : reason);
@@ -353,6 +358,7 @@ public class ChangeHookRunner implements ChangeHooks {
addArg(args, "--change-url", event.change.url);
addArg(args, "--project", event.change.project);
addArg(args, "--branch", event.change.branch);
addArg(args, "--topic", event.change.topic);
addArg(args, "--restorer", getDisplayName(account));
addArg(args, "--reason", reason == null ? "" : reason);