opendev/gerrit
Code Issues Proposed changes

Let plugins avoid sending comments when replying

Browse Source 
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705511
Change-Id: Ie0ab13d3b99ae008376353dce0702e1597edd1b8
This commit is contained in:
Aaron Gable
2017-05-05 14:48:41 -07:00
parent b19d1b947d
commit ab9bf5c263
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-change-reply-js-api.js
View File

@@ -22,8 +22,8 @@
this._el.setLabelValue(label, value);
};
GrChangeReplyInterface.prototype.send = function() {
return this._el.send();
GrChangeReplyInterface.prototype.send = function(opt_includeComments) {
return this._el.send(opt_includeComments);
};
window.GrChangeReplyInterface = GrChangeReplyInterface;

4
polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-change-reply-js-api_test.html
View File

@@ -66,8 +66,8 @@ limitations under the License.
assert(setLabelValueStub.calledWithExactly('My-Label', '+1337'));
var sendStub = sinon.stub(element, 'send');
changeReply.send();
assert(sendStub.calledWithExactly());
changeReply.send(false);
assert(sendStub.calledWithExactly(false));
});
});
</script>