opendev/gerrit
Code Issues Proposed changes

Console log and reporting on invalid comment ranges

Browse Source 
Change-Id: Ie1f0172cee1d7b4a2e78d5eb8c60745162f650f1
This commit is contained in:
Wyatt Allen
2017-03-14 11:06:25 -07:00
parent 515c2e437e
commit acf90d192d
3 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/core/gr-reporting/gr-reporting.js
View File

@@ -192,8 +192,8 @@
delete this._baselines[name];
},
reportInteraction: function(eventName) {
this.reporter(INTERACTION_TYPE, this.category, eventName);
reportInteraction: function(eventName, opt_msg) {
this.reporter(INTERACTION_TYPE, this.category, eventName, opt_msg);
},
});

4
polygerrit-ui/app/elements/diff/gr-ranged-comment-layer/gr-ranged-comment-layer.html
View File

@@ -15,7 +15,11 @@ limitations under the License.
-->
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../core/gr-reporting/gr-reporting.html">
<dom-module id="gr-ranged-comment-layer">
<template>
<gr-reporting id="reporting" category="comments"></gr-reporting>
</template>
<script src="../gr-diff-highlight/gr-annotation.js"></script>
<script src="gr-ranged-comment-layer.js"></script>
</dom-module>

7
polygerrit-ui/app/elements/diff/gr-ranged-comment-layer/gr-ranged-comment-layer.js
View File

@@ -20,6 +20,8 @@
var RANGE_HIGHLIGHT = 'range';
var HOVER_HIGHLIGHT = 'rangeHighlight';
var NORMALIZE_RANGE_EVENT = 'normalize-range';
Polymer({
is: 'gr-ranged-comment-layer',
@@ -181,10 +183,13 @@
// @see Issue 5744
if (range.start >= range.end && range.start < line.text.length) {
range.end = line.text.length;
this.$.reporting.reportInteraction(NORMALIZE_RANGE_EVENT,
'Modified invalid comment range on l.' + lineNum +
' of the ' + side + ' side');
}
return range;
})
}.bind(this))
.sort(function(a, b) {
// Sort the ranges so that hovering highlights are on top.
return a.hovering && !b.hovering ? 1 : 0;