opendev/gerrit
Code Issues Proposed changes

Add small tests for TestProjectUpdate and nested classes

Browse Source 
Change-Id: I1807646696e5117a3c55599c914ca1a4128e8dfb
This commit is contained in:
Dave Borowitz
2019-05-21 12:51:48 +02:00
parent 9eaac4aaea
commit ad155f971b
2 changed files with 133 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/acceptance/testsuite/project/TestProjectUpdate.java
View File

@@ -74,6 +74,7 @@ public abstract class TestProjectUpdate {
/** Sets the minimum and maximum values for the capability. */
public Builder range(int min, int max) {
checkArgument(min != 0 || max != 0, "empty range");
return min(min).max(max);
}
@@ -362,11 +363,11 @@ public abstract class TestProjectUpdate {
abstract Builder projectUpdater(ThrowingConsumer<TestProjectUpdate> projectUpdater);
abstract TestProjectUpdate autoBuild();
abstract TestProjectUpdate build();
/** Executes the update, updating the underlying project. */
public void update() {
TestProjectUpdate projectUpdate = autoBuild();
TestProjectUpdate projectUpdate = build();
projectUpdate.projectUpdater().acceptAndThrowSilently(projectUpdate);
}
}
@@ -384,6 +385,8 @@ public abstract class TestProjectUpdate {
abstract ThrowingConsumer<TestProjectUpdate> projectUpdater();
private static void checkLabelName(String name) {
// "label-Code-Review" is technically a valid label name, and we don't prevent users from
// using it in production, but specifying it in a test is programmer error.
checkArgument(!Permission.isLabel(name), "expected label name, got permission name: %s", name);
LabelType.checkName(name);
}

128
javatests/com/google/gerrit/acceptance/testsuite/project/TestProjectUpdateTest.java Normal file
View File

@@ -0,0 +1,128 @@
// Copyright (C) 2019 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.acceptance.testsuite.project;
import static com.google.common.truth.Truth.assertThat;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.allowCapability;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.allowLabel;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.capabilityKey;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.labelPermissionKey;
import static com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.permissionKey;
import static com.google.gerrit.common.data.GlobalCapability.ADMINISTRATE_SERVER;
import static com.google.gerrit.common.data.GlobalCapability.BATCH_CHANGES_LIMIT;
import static com.google.gerrit.common.data.GlobalCapability.DEFAULT_MAX_BATCH_CHANGES_LIMIT;
import static com.google.gerrit.common.data.GlobalCapability.DEFAULT_MAX_QUERY_LIMIT;
import static com.google.gerrit.common.data.GlobalCapability.QUERY_LIMIT;
import static com.google.gerrit.common.data.Permission.ABANDON;
import static com.google.gerrit.server.group.SystemGroupBackend.REGISTERED_USERS;
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
import com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.TestLabelPermission;
import com.google.gerrit.acceptance.testsuite.project.TestProjectUpdate.TestPermissionKey;
import java.util.function.Function;
import org.junit.Test;
public class TestProjectUpdateTest {
@Test
public void testCapabilityDisallowsZeroRange() throws Exception {
assertThrows(
RuntimeException.class,
() -> allowCapability(ADMINISTRATE_SERVER).group(REGISTERED_USERS).range(0, 0).build());
assertThrows(
RuntimeException.class,
() -> allowCapability(QUERY_LIMIT).group(REGISTERED_USERS).range(0, 0).build());
}
@Test
public void testCapabilityDisallowsRangeIfCapabilityDoesNotSupportRange() throws Exception {
assertThrows(
RuntimeException.class,
() -> allowCapability(ADMINISTRATE_SERVER).group(REGISTERED_USERS).range(-1, 1).build());
}
@Test
public void testCapabilityRangeIsZeroIfCapabilityDoesNotSupportRange() throws Exception {
TestProjectUpdate.TestCapability c =
allowCapability(ADMINISTRATE_SERVER).group(REGISTERED_USERS).build();
assertThat(c.min()).isEqualTo(0);
assertThat(c.max()).isEqualTo(0);
}
@Test
public void testCapabilityUsesDefaultRangeIfUnspecified() throws Exception {
TestProjectUpdate.TestCapability c =
allowCapability(QUERY_LIMIT).group(REGISTERED_USERS).build();
assertThat(c.min()).isEqualTo(0);
assertThat(c.max()).isEqualTo(DEFAULT_MAX_QUERY_LIMIT);
c = allowCapability(BATCH_CHANGES_LIMIT).group(REGISTERED_USERS).build();
assertThat(c.min()).isEqualTo(0);
assertThat(c.max()).isEqualTo(DEFAULT_MAX_BATCH_CHANGES_LIMIT);
}
@Test
public void testCapabilityUsesExplicitRangeIfSpecified() throws Exception {
TestProjectUpdate.TestCapability c =
allowCapability(QUERY_LIMIT).group(REGISTERED_USERS).range(5, 20).build();
assertThat(c.min()).isEqualTo(5);
assertThat(c.max()).isEqualTo(20);
}
@Test
public void testLabelPermissionRequiresValidLabelName() throws Exception {
Function<String, TestLabelPermission.Builder> labelBuilder =
name -> allowLabel(name).ref("refs/*").group(REGISTERED_USERS).range(-1, 1);
assertThat(labelBuilder.apply("Code-Review").build().name()).isEqualTo("Code-Review");
assertThrows(RuntimeException.class, () -> labelBuilder.apply("not a label").build());
assertThrows(RuntimeException.class, () -> labelBuilder.apply("label-Code-Review").build());
}
@Test
public void testPermissionKeyRequiresValidRefName() throws Exception {
Function<String, TestPermissionKey.Builder> keyBuilder =
ref -> permissionKey(ABANDON).ref(ref).group(REGISTERED_USERS);
assertThat(keyBuilder.apply("refs/*").build().section()).isEqualTo("refs/*");
assertThrows(RuntimeException.class, () -> keyBuilder.apply(null).build());
assertThrows(RuntimeException.class, () -> keyBuilder.apply("foo").build());
}
@Test
public void testLabelPermissionKeyRequiresValidLabelName() throws Exception {
Function<String, TestPermissionKey.Builder> keyBuilder =
label -> labelPermissionKey(label).ref("refs/*").group(REGISTERED_USERS);
assertThat(keyBuilder.apply("Code-Review").build().name()).isEqualTo("label-Code-Review");
assertThrows(RuntimeException.class, () -> keyBuilder.apply(null).build());
assertThrows(RuntimeException.class, () -> keyBuilder.apply("not a label").build());
assertThrows(RuntimeException.class, () -> keyBuilder.apply("label-Code-Review").build());
}
@Test
public void testPermissionKeyDisallowsSettingRefOnGlobalCapability() throws Exception {
assertThrows(RuntimeException.class, () -> capabilityKey(ADMINISTRATE_SERVER).ref("refs/*"));
}
@Test
public void testProjectUpdateDisallowsGroupOnExclusiveGroupPermissionKey() throws Exception {
TestPermissionKey.Builder b = permissionKey(ABANDON).ref("refs/*");
Function<TestPermissionKey.Builder, TestProjectUpdate.Builder> updateBuilder =
kb -> TestProjectUpdate.builder(u -> {}).setExclusiveGroup(kb, true);
assertThat(updateBuilder.apply(b).build().exclusiveGroupPermissions())
.containsExactly(b.build(), true);
b.group(REGISTERED_USERS);
assertThrows(RuntimeException.class, () -> updateBuilder.apply(b).build());
}
}