Merge "A11y - Keyboard focus moves only to interactive elements on Dashboard"

This commit is contained in:
Milutin Kristofic
2020-06-19 11:51:16 +00:00
committed by Gerrit Code Review
3 changed files with 6 additions and 9 deletions

View File

@@ -45,13 +45,6 @@ export const htmlTemplate = html`
white-space: nowrap;
width: 100%;
}
.content a {
display: block;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
width: 100%;
}
.comments,
.reviewers {
white-space: nowrap;

View File

@@ -168,7 +168,6 @@ class GrChangeList extends mixinBehaviors( [
/** @override */
ready() {
super.ready();
this._ensureAttribute('tabindex', 0);
this.$.restAPI.getConfig().then(config => {
this._config = config;
});
@@ -296,6 +295,11 @@ class GrChangeList extends mixinBehaviors( [
return idx == selectedIndex;
}
_computeTabIndex(sectionIndex, index, selectedIndex) {
return this._computeItemSelected(sectionIndex, index, selectedIndex)
? 0 : undefined;
}
_computeItemNeedsReview(account, change, showReviewedState) {
return showReviewedState && !change.reviewed &&
!change.work_in_progress &&

View File

@@ -138,7 +138,7 @@ export const htmlTemplate = html`
visible-change-table-columns="[[visibleChangeTableColumns]]"
show-number="[[showNumber]]"
show-star="[[showStar]]"
tabindex="0"
tabindex$="[[_computeTabIndex(sectionIndex, index, selectedIndex)]]"
label-names="[[labelNames]]"
></gr-change-list-item>
</template>