opendev/gerrit
Code Issues Proposed changes

Fix circular dependencies in ts files

Browse Source 
Change-Id: Icb88c66ff2707f202ecf75f5d893cc81a2d10545
This commit is contained in:
Dmitrii Filippov
2020-08-13 15:04:27 +02:00
parent ffada5a2a1
commit b32b5d467b
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/scripts/gr-reviewer-suggestions-provider/gr-reviewer-suggestions-provider.ts
View File

@@ -26,6 +26,7 @@ import {
NumericChangeId,
ServerInfo,
SuggestedReviewerInfo,
Suggestion,
} from '../../types/common';
import {assertNever} from '../../utils/common-util';
@@ -37,8 +38,6 @@ export enum SUGGESTIONS_PROVIDERS_USERS_TYPES {
ANY = 'any',
}
export type Suggestion = SuggestedReviewerInfo | AccountInfo;
export function isAccountSuggestions(s: Suggestion): s is AccountInfo {
return (s as AccountInfo)._account_id !== undefined;
}

3
polygerrit-ui/app/types/common.ts
View File

@@ -43,7 +43,6 @@ import {
DraftsAction,
NotifyType,
} from '../constants/constants';
import {Suggestion} from '../scripts/gr-reviewer-suggestions-provider/gr-reviewer-suggestions-provider';
export type BrandType<T, BrandName extends string> = T &
{[__brand in BrandName]: never};
@@ -1831,6 +1830,8 @@ export type SuggestedReviewerInfo =
| SuggestedReviewerAccountInfo
| SuggestedReviewerGroupInfo;
export type Suggestion = SuggestedReviewerInfo | AccountInfo;
export function isReviewerAccountSuggestion(
s: Suggestion
): s is SuggestedReviewerAccountInfo {