opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.9'

Browse Source 
* stable-2.9:
  Review UI docs: Add screenshot of side-by-side diff with renamed file
  Review UI docs: Move sentence about download icon to right place
  Apache/mod_jk/web server: Describe ForwardURICompatUnparsed option

Change-Id: I15f752c80bc45f368e4dde4e6d31758c530fa0ce
This commit is contained in:
David Pursehouse 2014-06-09 11:37:50 +09:00
commit b366536987
3 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Documentation/config-reverseproxy.txt
View File

@ -135,6 +135,14 @@ screen, your Nginx proxy is very likely decoding the passed URL.
Make sure to use a 'proxy_pass' URL without any path (esp. no trailing
'/' after the 'host:port').
If you are using Apache httpd server with mod_jk and AJP connector, add
the following option to your httpd.conf directly or included from another
file:
----
JkOptions +ForwardURICompatUnparsed
----
GERRIT
------
Part of link:index.html[Gerrit Code Review]

BIN
Documentation/images/user-review-ui-side-by-side-diff-screen-rename.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 56 KiB

12
Documentation/user-review-ui.txt
View File

@ -756,14 +756,20 @@ comparing the old patch against the current patch.
image::images/user-review-ui-side-by-side-diff-screen-patch-sets.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-patch-sets.png"]
The download icon next to the patch set list allows to download the
patch. Unless the mime type of the file is configured as safe, the
download file is a zip archive that contains the patch file.
If the compared patches are identical, this is highlighted by a red
`No Differences` label in the screen header.
image::images/user-review-ui-side-by-side-diff-screen-no-differences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-no-differences.png"]
The download icon next to the patch set list allows to download the
patch. Unless the mime type of the file is configured as safe, the
download file is a zip archive that contains the patch file.
If a file was renamed, the old and new file paths are shown in the
header together with a similarity index that shows how much of the file
content is unmodified.
image::images/user-review-ui-side-by-side-diff-screen-rename.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-rename.png"]
For navigating between the patches in a patch set there are navigation
buttons on the right side of the screen header. The left arrow button