opendev/gerrit
Code Issues Proposed changes

Fix input object of IndexChanges REST endpoint

Browse Source 
This REST endpoint shouldn't accept any input, but it was wrongly
accepting a ProjectInput (which is used by the Create Project REST
endpoint to specify the properties of a new project).

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Iaada3114e11dccba474f3e26101017a576998b79
This commit is contained in:
Edwin Kempin
2019-07-11 17:13:36 +02:00
committed by David Pursehouse
parent 7b856b1834
commit bb40fe23c8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/com/google/gerrit/server/restapi/project/IndexChanges.java
View File

@@ -20,7 +20,7 @@ import com.google.common.io.ByteStreams;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.extensions.annotations.RequiresCapability;
import com.google.gerrit.extensions.api.projects.ProjectInput;
import com.google.gerrit.extensions.common.Input;
import com.google.gerrit.extensions.restapi.Response;
import com.google.gerrit.extensions.restapi.RestModifyView;
import com.google.gerrit.reviewdb.client.Project;
@@ -38,7 +38,7 @@ import org.eclipse.jgit.util.io.NullOutputStream;
@RequiresCapability(GlobalCapability.ADMINISTRATE_SERVER)
@Singleton
public class IndexChanges implements RestModifyView<ProjectResource, ProjectInput> {
public class IndexChanges implements RestModifyView<ProjectResource, Input> {
private final Provider<AllChangesIndexer> allChangesIndexerProvider;
private final ChangeIndexer indexer;
@@ -55,7 +55,7 @@ public class IndexChanges implements RestModifyView<ProjectResource, ProjectInpu
}
@Override
public Response.Accepted apply(ProjectResource resource, ProjectInput input) {
public Response.Accepted apply(ProjectResource resource, Input input) {
Project.NameKey project = resource.getNameKey();
Task mpt =
new MultiProgressMonitor(ByteStreams.nullOutputStream(), "Reindexing project")