opendev/gerrit
Code Issues Proposed changes

ExportReviewNotes: Default to 2 threads

Browse Source 
Not all systems have enough database connections in the connection
pool to support 2 threads per CPU. Exporting lots of changes doesn't
take that long, so 2 threads is acceptable.

Change-Id: I69bbade7f67023689ca54665833bc764d2d5503d
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2011-05-31 09:52:38 -07:00
parent 1f412fe330
commit bf9d9ed987
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/pgm-ExportReviewNotes.txt
View File

@@ -29,8 +29,7 @@ OPTIONS
configuration data, supporting libaries and log files. configuration data, supporting libaries and log files.
\--threads:: \--threads::
Number of threads to perform the scan work with. Defaults to Number of threads to perform the scan work with. Default: 2.
twice the number of CPUs available.
CONTEXT CONTEXT
------- -------

2
gerrit-pgm/src/main/java/com/google/gerrit/pgm/ExportReviewNotes.java
View File

@@ -63,7 +63,7 @@ import java.util.Map.Entry;
/** Export review notes for all submitted changes in all projects. */ /** Export review notes for all submitted changes in all projects. */
public class ExportReviewNotes extends SiteProgram { public class ExportReviewNotes extends SiteProgram {
@Option(name = "--threads", usage = "Number of concurrent threads to run") @Option(name = "--threads", usage = "Number of concurrent threads to run")
private int threads = 2 * Runtime.getRuntime().availableProcessors(); private int threads = 2;
private final LifecycleManager manager = new LifecycleManager(); private final LifecycleManager manager = new LifecycleManager();
private final TextProgressMonitor textMonitor = new TextProgressMonitor(); private final TextProgressMonitor textMonitor = new TextProgressMonitor();