opendev/gerrit
Code Issues Proposed changes

Fix the alignment of the placeholder in reply dialog

Browse Source 
"Add reviewer..." was vertically not correctly positioned.

Also reduce/align the vertical heights and margins a little, and use
a little bit less space for the "Reviewers" and "CC" labels.

Change-Id: I1ac7a64fb426218ee1ba0b4e999b7b29f4b4275d
This commit is contained in:
Ben Rohlfs
2020-01-24 12:18:58 +01:00
parent 8f716d7c02
commit c499ed333b
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.html
View File

@@ -86,19 +86,17 @@ limitations under the License.
} }
.peopleList { .peopleList {
display: flex; display: flex;
padding-top: var(--spacing-xxs);
} }
.peopleListLabel { .peopleListLabel {
color: var(--deemphasized-text-color); color: var(--deemphasized-text-color);
margin-top: var(--spacing-xs); margin-top: var(--spacing-xs);
min-width: 7em; min-width: 6em;
padding-right: var(--spacing-m); padding-right: var(--spacing-m);
} }
gr-account-list { gr-account-list {
display: flex; display: flex;
flex-wrap: wrap; flex-wrap: wrap;
flex: 1; flex: 1;
min-height: 1.8em;
} }
#reviewerConfirmationOverlay { #reviewerConfirmationOverlay {
padding: var(--spacing-l); padding: var(--spacing-l);

1
polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.html
View File

@@ -32,6 +32,7 @@ limitations under the License.
display: flex; display: flex;
flex: 1; flex: 1;
min-width: 10em; min-width: 10em;
margin: var(--spacing-xs) var(--spacing-xs) var(--spacing-xs) 0;
} }
.group { .group {
--account-label-suffix: ' (group)'; --account-label-suffix: ' (group)';