opendev/gerrit
Code Issues Proposed changes

Use better help text for editing topics

Browse Source 
Specifically, we use "edit" instead of "alter".  This change also
stores the edit text label appropriately in properties.

Change-Id: Ia6934649b9a68464e163d446ae65f62be67f5dea
This commit is contained in:
Conley Owens
2012-11-13 17:39:53 -08:00
parent 66c01952ef
commit c516c6336a
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.java
View File

@@ -107,6 +107,7 @@ public interface ChangeConstants extends Constants {
String buttonAlterTopicCancel();
String headingAlterTopicMessage();
String alterTopicTitle();
String alterTopicLabel();
String includedInTableBranch();
String includedInTableTag();

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties
View File

@@ -78,12 +78,13 @@ changeInfoBlockCanMerge = Can Merge
changeInfoBlockCanMergeYes = Yes
changeInfoBlockCanMergeNo = No
buttonAlterTopic = Alter Topic
buttonAlterTopicBegin = Alter Topic
buttonAlterTopic = Edit Topic
buttonAlterTopicBegin = Edit Topic
buttonAlterTopicSend = Update Topic
buttonAlterTopicCancel = Cancel
headingAlterTopicMessage = Alter Topic Branch Message:
alterTopicTitle = Code Review - Alter Topic
headingAlterTopicMessage = Edit Topic Message:
alterTopicTitle = Code Review - Edit Topic
alterTopicLabel = Edit Topic To:
includedInTableBranch = Branch Name
includedInTableTag = Tag Name

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfoBlock.java
View File

@@ -163,7 +163,7 @@ public class ChangeInfoBlock extends Composite {
newTopic = new TextBox();
panel.insert(newTopic, 0);
panel.insert(new InlineLabel("Alter topic to:"), 0);
panel.insert(new InlineLabel(Util.C.alterTopicLabel()), 0);
}
@Override