opendev/gerrit
Code Issues Proposed changes

Fix gr-permission test under Polymer 2

Browse Source 
Change-Id: I3a9d361bd239e734cf1353816a1144c4101d1610
This commit is contained in:
Paladox none
2019-07-27 20:41:35 +00:00
parent b628b3a5a5
commit c610ae1c2a
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
polygerrit-ui/app/elements/admin/gr-permission/gr-permission_test.html
View File

@@ -329,8 +329,17 @@ limitations under the License.
name: 'ldap/tests tests'}});
assert.equal(element._rules.length, 3);
assert.equal(Object.keys(element._groupsWithRules).length, 3);
assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
{action: 'ALLOW', min: -2, max: 2, added: true});
if (Polymer.Element) {
// Under Polymer 2 gr-rule-editor.js#_handleValueChange get's
// fully loaded before this change, thus `modified: true` get's managed
// to be added. Under Polymer 1 it was a mix hence why it was not
// added in time for when this test ran.
assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
{action: 'ALLOW', min: -2, max: 2, modified: true, added: true});
} else {
assert.deepEqual(element.permission.value.rules['ldap:CN=test test'],
{action: 'ALLOW', min: -2, max: 2, added: true});
}
// New rule should be removed if cancel from editing.
element.editing = false;
assert.equal(element._rules.length, 2);