opendev/gerrit
Code Issues Proposed changes

Fix var scoping issue while doing intraline highlights

Browse Source 
+ I hate var scoping in JS.
+ Also update server.go to point to Gerrit.

Change-Id: I9bb035cd7eca5d5c029052611ea28b7d67fd6f98
This commit is contained in:
Andrew Bonventre
2016-03-29 17:16:09 -04:00
parent f5956d2da5
commit c6857c537c
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/diff/gr-diff/gr-diff-builder.js
View File

@@ -95,7 +95,7 @@
} }
if (group[GrDiffBuilder.GroupType.REMOVED] !== undefined) { if (group[GrDiffBuilder.GroupType.REMOVED] !== undefined) {
var highlights; var highlights = undefined;
if (group[GrDiffBuilder.Highlights.REMOVED] !== undefined) { if (group[GrDiffBuilder.Highlights.REMOVED] !== undefined) {
highlights = this._normalizeIntralineHighlights( highlights = this._normalizeIntralineHighlights(
group[GrDiffBuilder.GroupType.REMOVED], group[GrDiffBuilder.GroupType.REMOVED],
@@ -106,7 +106,7 @@
} }
if (group[GrDiffBuilder.GroupType.ADDED] !== undefined) { if (group[GrDiffBuilder.GroupType.ADDED] !== undefined) {
var highlights; var highlights = undefined;
if (group[GrDiffBuilder.Highlights.ADDED] !== undefined) { if (group[GrDiffBuilder.Highlights.ADDED] !== undefined) {
highlights = this._normalizeIntralineHighlights( highlights = this._normalizeIntralineHighlights(
group[GrDiffBuilder.GroupType.ADDED], group[GrDiffBuilder.GroupType.ADDED],

2
polygerrit-ui/server.go
View File

@@ -30,7 +30,7 @@ import (
) )
var ( var (
restHost = flag.String("host", "canary-chromium-review.googlesource.com", "Host to proxy requests to") restHost = flag.String("host", "gerrit-review.googlesource.com", "Host to proxy requests to")
port = flag.String("port", ":8081", "Port to serve HTTP requests on") port = flag.String("port", ":8081", "Port to serve HTTP requests on")
prod = flag.Bool("prod", false, "Serve production assets") prod = flag.Bool("prod", false, "Serve production assets")
loggedIn = flag.Bool("logged_in", false, "Return user info as if the user is logged in") loggedIn = flag.Bool("logged_in", false, "Return user info as if the user is logged in")