opendev/gerrit
Code Issues Proposed changes

ExternalIdIT: Migrate from try-catch-fail to assertThrows

Browse Source 
Change-Id: Iac1eb92799e5007b4b09c72bced3eb597989534b
This commit is contained in:
David Pursehouse
2019-05-22 17:02:32 +09:00
parent e6240e2c13
commit ca847cf70b
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
javatests/com/google/gerrit/acceptance/rest/account/ExternalIdIT.java
View File

@@ -258,24 +258,22 @@ public class ExternalIdIT extends AbstractDaemonTest {
@Test
public void fetchExternalIdsBranch() throws Exception {
TestRepository<InMemoryRepository> allUsersRepo = cloneProject(allUsers, user);
final TestRepository<InMemoryRepository> allUsersRepo = cloneProject(allUsers, user);
// refs/meta/external-ids is only visible to users with the 'Access Database' capability
try {
fetch(allUsersRepo, RefNames.REFS_EXTERNAL_IDS);
fail("expected TransportException");
} catch (TransportException e) {
assertThat(e.getMessage())
.isEqualTo(
"Remote does not have " + RefNames.REFS_EXTERNAL_IDS + " available for fetch.");
}
TransportException thrown =
assertThrows(
TransportException.class, () -> fetch(allUsersRepo, RefNames.REFS_EXTERNAL_IDS));
assertThat(thrown)
.hasMessageThat()
.isEqualTo("Remote does not have " + RefNames.REFS_EXTERNAL_IDS + " available for fetch.");
allowGlobalCapabilities(REGISTERED_USERS, GlobalCapability.ACCESS_DATABASE);
// re-clone to get new request context, otherwise the old global capabilities are still cached
// in the IdentifiedUser object
allUsersRepo = cloneProject(allUsers, user);
fetch(allUsersRepo, RefNames.REFS_EXTERNAL_IDS);
TestRepository<InMemoryRepository> allUsersRepo2 = cloneProject(allUsers, user);
fetch(allUsersRepo2, RefNames.REFS_EXTERNAL_IDS);
}
@Test