Merge changes from topic "gr-registration-dialog-to-ts"

* changes:
  Convert gr-registration-dialog to typescript
  Rename files to preserve history
This commit is contained in:
Dmitrii Filippov
2020-08-18 13:57:42 +00:00
committed by Gerrit Code Review
2 changed files with 174 additions and 163 deletions

View File

@@ -1,163 +0,0 @@
/**
* @license
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import '@polymer/iron-input/iron-input.js';
import '../../../styles/gr-form-styles.js';
import '../../shared/gr-button/gr-button.js';
import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
import '../../../styles/shared-styles.js';
import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mixin.js';
import {PolymerElement} from '@polymer/polymer/polymer-element.js';
import {htmlTemplate} from './gr-registration-dialog_html.js';
/**
* @extends PolymerElement
*/
class GrRegistrationDialog extends GestureEventListeners(
LegacyElementMixin(PolymerElement)) {
static get template() { return htmlTemplate; }
static get is() { return 'gr-registration-dialog'; }
/**
* Fired when account details are changed.
*
* @event account-detail-update
*/
/**
* Fired when the close button is pressed.
*
* @event close
*/
static get properties() {
return {
settingsUrl: String,
/** @type {?} */
_account: {
type: Object,
value: () => {
// Prepopulate possibly undefined fields with values to trigger
// computed bindings.
return {email: null, name: null, username: null};
},
},
_usernameMutable: {
type: Boolean,
computed: '_computeUsernameMutable(_serverConfig, _account.username)',
},
_loading: {
type: Boolean,
value: true,
observer: '_loadingChanged',
},
_saving: {
type: Boolean,
value: false,
},
_serverConfig: Object,
};
}
/** @override */
ready() {
super.ready();
this._ensureAttribute('role', 'dialog');
}
loadData() {
this._loading = true;
const loadAccount = this.$.restAPI.getAccount().then(account => {
// Using Object.assign here allows preservation of the default values
// supplied in the value generating function of this._account, unless
// they are overridden by properties in the account from the response.
this._account = {...this._account, ...account};
});
const loadConfig = this.$.restAPI.getConfig().then(config => {
this._serverConfig = config;
});
return Promise.all([loadAccount, loadConfig]).then(() => {
this._loading = false;
});
}
_save() {
this._saving = true;
const promises = [
this.$.restAPI.setAccountName(this.$.name.value),
this.$.restAPI.setPreferredAccountEmail(this.$.email.value || ''),
];
if (this._usernameMutable) {
promises.push(this.$.restAPI.setAccountUsername(this.$.username.value));
}
return Promise.all(promises).then(() => {
this._saving = false;
this.dispatchEvent(new CustomEvent('account-detail-update', {
composed: true, bubbles: true,
}));
});
}
_handleSave(e) {
e.preventDefault();
this._save().then(this.close.bind(this));
}
_handleClose(e) {
e.preventDefault();
this.close();
}
close() {
this._saving = true; // disable buttons indefinitely
this.dispatchEvent(new CustomEvent('close', {
composed: true, bubbles: true,
}));
}
_computeSaveDisabled(name, email, saving) {
return !name || !email || saving;
}
_computeUsernameMutable(config, username) {
// Polymer 2: check for undefined
if ([
config,
username,
].includes(undefined)) {
return undefined;
}
return config.auth.editable_account_fields.includes('USER_NAME') &&
!username;
}
_computeUsernameClass(usernameMutable) {
return usernameMutable ? '' : 'hide';
}
_loadingChanged() {
this.classList.toggle('loading', this._loading);
}
}
customElements.define(GrRegistrationDialog.is, GrRegistrationDialog);

View File

@@ -0,0 +1,174 @@
/**
* @license
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import '@polymer/iron-input/iron-input';
import '../../../styles/gr-form-styles';
import '../../shared/gr-button/gr-button';
import '../../shared/gr-rest-api-interface/gr-rest-api-interface';
import '../../../styles/shared-styles';
import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners';
import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mixin';
import {PolymerElement} from '@polymer/polymer/polymer-element';
import {htmlTemplate} from './gr-registration-dialog_html';
import {customElement, property, observe} from '@polymer/decorators';
import {ServerInfo, AccountDetailInfo} from '../../../types/common';
import {GrRestApiInterface} from '../../shared/gr-rest-api-interface/gr-rest-api-interface';
export interface GrRegistrationDialog {
$: {
restAPI: GrRestApiInterface;
name: HTMLInputElement;
username: HTMLInputElement;
email: HTMLSelectElement;
};
}
declare global {
interface HTMLElementTagNameMap {
'gr-registration-dialog': GrRegistrationDialog;
}
}
@customElement('gr-registration-dialog')
export class GrRegistrationDialog extends GestureEventListeners(
LegacyElementMixin(PolymerElement)
) {
static get template() {
return htmlTemplate;
}
/**
* Fired when account details are changed.
*
* @event account-detail-update
*/
/**
* Fired when the close button is pressed.
*
* @event close
*/
@property({type: String})
settingsUrl?: string;
@property({type: Object})
_account: Partial<AccountDetailInfo> = {};
@property({type: Boolean})
_loading = true;
@property({type: Boolean})
_saving = false;
@property({type: Object})
_serverConfig?: ServerInfo;
@property({
computed: '_computeUsernameMutable(_serverConfig,_account.username)',
type: Boolean,
})
_usernameMutable = false;
/** @override */
ready() {
super.ready();
this._ensureAttribute('role', 'dialog');
}
_computeUsernameMutable(config?: ServerInfo, username?: string) {
// Polymer 2: check for undefined
// username is not being checked for undefined as we want to avoid
// setting it null explicitly to trigger the computation
if (config === undefined) {
return false;
}
return (
config.auth.editable_account_fields.includes('USER_NAME') && !username
);
}
loadData() {
this._loading = true;
const loadAccount = this.$.restAPI.getAccount().then(account => {
this._account = {...this._account, ...account};
});
const loadConfig = this.$.restAPI.getConfig().then(config => {
this._serverConfig = config;
});
return Promise.all([loadAccount, loadConfig]).then(() => {
this._loading = false;
});
}
_save() {
this._saving = true;
const promises = [
this.$.restAPI.setAccountName(this.$.name.value),
this.$.restAPI.setPreferredAccountEmail(this.$.email.value || ''),
];
if (this._usernameMutable) {
promises.push(this.$.restAPI.setAccountUsername(this.$.username.value));
}
return Promise.all(promises).then(() => {
this._saving = false;
this.dispatchEvent(
new CustomEvent('account-detail-update', {
composed: true,
bubbles: true,
})
);
});
}
_handleSave(e: Event) {
e.preventDefault();
this._save().then(() => this.close());
}
_handleClose(e: Event) {
e.preventDefault();
this.close();
}
close() {
this._saving = true; // disable buttons indefinitely
this.dispatchEvent(
new CustomEvent('close', {
composed: true,
bubbles: true,
})
);
}
_computeSaveDisabled(name?: string, email?: string, saving?: boolean) {
return !name || !email || saving;
}
_computeUsernameClass(usernameMutable: boolean) {
return usernameMutable ? '' : 'hide';
}
@observe('_loading')
_loadingChanged() {
this.classList.toggle('loading', this._loading);
}
}