opendev/gerrit
Code Issues Proposed changes

Permit all registered users to use the code review -1/+1 category

Browse Source 
This is just reasonable to do, and what Gerrit 1 permits.  Users who
have registered an account may use the -1, 0, +1 values in the CRVW
category (aka "Code Review") to vote on changes, even if they are not
a member of the project.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-01-03 15:00:43 -08:00
parent d0207f556a
commit cdb631ff28
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
appjar/src/main/java/com/google/gerrit/server/GerritServer.java
View File

@@ -20,6 +20,7 @@ import com.google.gerrit.client.data.GitwebLink;
import com.google.gerrit.client.reviewdb.AccountGroup; import com.google.gerrit.client.reviewdb.AccountGroup;
import com.google.gerrit.client.reviewdb.ApprovalCategory; import com.google.gerrit.client.reviewdb.ApprovalCategory;
import com.google.gerrit.client.reviewdb.ApprovalCategoryValue; import com.google.gerrit.client.reviewdb.ApprovalCategoryValue;
import com.google.gerrit.client.reviewdb.ProjectRight;
import com.google.gerrit.client.reviewdb.ReviewDb; import com.google.gerrit.client.reviewdb.ReviewDb;
import com.google.gerrit.client.reviewdb.SystemConfig; import com.google.gerrit.client.reviewdb.SystemConfig;
import com.google.gerrit.git.RepositoryCache; import com.google.gerrit.git.RepositoryCache;
@@ -214,6 +215,13 @@ public class GerritServer {
c.approvalCategories().insert(Collections.singleton(cat), txn); c.approvalCategories().insert(Collections.singleton(cat), txn);
c.approvalCategoryValues().insert(vals); c.approvalCategoryValues().insert(vals);
txn.commit(); txn.commit();
final ProjectRight approve =
new ProjectRight(new ProjectRight.Key(ProjectRight.WILD_PROJECT, cat
.getId(), sConfig.registeredGroupId));
approve.setMaxValue((short) 1);
approve.setMinValue((short) -1);
c.projectRights().insert(Collections.singleton(approve));
} }
private void initSubmitCategory(final ReviewDb c) throws OrmException { private void initSubmitCategory(final ReviewDb c) throws OrmException {
@@ -253,10 +261,10 @@ public class GerritServer {
// Assume the schema is empty and populate it. // Assume the schema is empty and populate it.
// //
initSystemConfig(c); initSystemConfig(c);
sConfig = c.systemConfig().get(new SystemConfig.Key());
initVerifiedCategory(c); initVerifiedCategory(c);
initCodeReviewCategory(c); initCodeReviewCategory(c);
initSubmitCategory(c); initSubmitCategory(c);
sConfig = c.systemConfig().get(new SystemConfig.Key());
} }
loadGerritConfig(c); loadGerritConfig(c);