Merge "Clarify error message about FORGE_SERVER permission."

This commit is contained in:
Edwin Kempin
2017-08-14 08:53:28 +00:00
committed by Gerrit Code Review

View File

@@ -610,9 +610,15 @@ public class CommitValidators {
&& author.getName().equals(gerritIdent.getName())
&& author.getEmailAddress().equals(gerritIdent.getEmailAddress())) {
try {
// Stop authors from amending the merge commits that Gerrit itself creates.
perm.check(RefPermission.FORGE_SERVER);
} catch (AuthException denied) {
throw new CommitValidationException("do not amend merges not made by you");
throw new CommitValidationException(
String.format(
"pushing merge commit %s by %s requires '%s' permission",
receiveEvent.commit.getId(),
gerritIdent.getEmailAddress(),
RefPermission.FORGE_SERVER.name()));
} catch (PermissionBackendException e) {
log.error("cannot check FORGE_SERVER", e);
throw new CommitValidationException("internal auth error");