Buck: Simplify build rules

Since [1] dependencies to targets used in $(exe //path/to:target) and
$(location //path/to:target) macros are added implicitly.

[1] https://github.com/facebook/buck/issues/128
Change-Id: Id98257e1118830205821e35816d0e562e56e961a
This commit is contained in:
David Ostrovsky 2015-06-05 08:03:40 +02:00
parent 61ff9a69ef
commit ddb3c62e5b
2 changed files with 0 additions and 12 deletions

View File

@ -18,10 +18,6 @@ genrule(
'unzip -qo $(location :ui_opt);' +
'mkdir -p \$(dirname $OUT);' +
'zip -qr $OUT .',
deps = [
':ui_dbg',
':ui_opt',
],
out = 'ui_optdbg.zip',
visibility = ['PUBLIC'],
)

View File

@ -22,16 +22,13 @@ def maven_package(
war = {}):
cmd = ['$(exe //tools/maven:mvn)', '-v', version, '-o', '$OUT']
api_cmd = []
api_deps = []
for type,d in [('jar', jar), ('java-source', src), ('javadoc', doc)]:
for a,t in d.iteritems():
api_cmd.append('-s %s:%s:$(location %s)' % (a,type,t))
api_deps.append(t)
genrule(
name = 'api_install',
cmd = ' '.join(cmd + api_cmd + ['-a', 'install']),
deps = api_deps + ['//tools/maven:mvn'],
out = 'api_install.info',
)
@ -42,20 +39,16 @@ def maven_package(
'-a', 'deploy',
'--repository', repository,
'--url', url]),
deps = api_deps + ['//tools/maven:mvn'],
out = 'api_deploy.info',
)
war_cmd = []
war_deps = []
for a,t in war.iteritems():
war_cmd.append('-s %s:war:$(location %s)' % (a,t))
war_deps.append(t)
genrule(
name = 'war_install',
cmd = ' '.join(cmd + war_cmd + ['-a', 'install']),
deps = war_deps + ['//tools/maven:mvn'],
out = 'war_install.info',
)
@ -66,6 +59,5 @@ def maven_package(
'-a', 'deploy',
'--repository', repository,
'--url', url]),
deps = war_deps + ['//tools/maven:mvn'],
out = 'war_deploy.info',
)