opendev/gerrit
Code Issues Proposed changes

Remove redundant 'final' modifier from private native methods

Browse Source 
Change-Id: I882e520dcbbd5ccead63e347b9d176ff11a59b6a
This commit is contained in:
David Pursehouse
2016-04-12 10:10:07 +09:00
parent b9e1788b69
commit dfcc5cd451
43 changed files with 129 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java
View File

@@ -40,9 +40,9 @@ public class AccountInfo extends JavaScriptObject {
return ts;
}
private final native String registeredOnRaw() /*-{ return this.registered_on; }-*/;
private final native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/;
private final native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/;
private native String registeredOnRaw() /*-{ return this.registered_on; }-*/;
private native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/;
private native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/;
/**
* @return true if the server supplied avatar information about this account.
@@ -64,7 +64,7 @@ public class AccountInfo extends JavaScriptObject {
return null;
}
private final native JsArray<AvatarInfo> avatars()
private native JsArray<AvatarInfo> avatars()
/*-{ return this.avatars }-*/;
public final native void name(String n) /*-{ this.name = n }-*/;

4
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java
View File

@@ -90,8 +90,8 @@ public class AuthInfo extends JavaScriptObject {
public final native String editFullNameUrl() /*-{ return this.edit_full_name_url; }-*/;
public final native String httpPasswordUrl() /*-{ return this.http_password_url; }-*/;
public final native boolean isGitBasicAuth() /*-{ return this.is_git_basic_auth || false; }-*/;
private final native String authTypeRaw() /*-{ return this.auth_type; }-*/;
private final native JsArrayString _editableAccountFields()
private native String authTypeRaw() /*-{ return this.auth_type; }-*/;
private native JsArrayString _editableAccountFields()
/*-{ return this.editable_account_fields; }-*/;
protected AuthInfo() {

28
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java
View File

@@ -71,8 +71,8 @@ public class ChangeInfo extends JavaScriptObject {
return revList.get(revList.length() - 1).isEdit();
}
private final native Timestamp _getCts() /*-{ return this._cts; }-*/;
private final native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/;
private native Timestamp _getCts() /*-{ return this._cts; }-*/;
private native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/;
public final Timestamp updated() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(updatedRaw());
@@ -112,12 +112,12 @@ public class ChangeInfo extends JavaScriptObject {
public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/;
public final native int insertions() /*-{ return this.insertions; }-*/;
public final native int deletions() /*-{ return this.deletions; }-*/;
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
public final native String subject() /*-{ return this.subject; }-*/;
public final native AccountInfo owner() /*-{ return this.owner; }-*/;
private final native String createdRaw() /*-{ return this.created; }-*/;
private final native String updatedRaw() /*-{ return this.updated; }-*/;
private final native String submittedRaw() /*-{ return this.submitted; }-*/;
private native String createdRaw() /*-{ return this.created; }-*/;
private native String updatedRaw() /*-{ return this.updated; }-*/;
private native String submittedRaw() /*-{ return this.submitted; }-*/;
public final native boolean starred() /*-{ return this.starred ? true : false; }-*/;
public final native boolean reviewed() /*-{ return this.reviewed ? true : false; }-*/;
public final native NativeMap<LabelInfo> allLabels() /*-{ return this.labels; }-*/;
@@ -142,7 +142,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native JsArray<AccountInfo> removableReviewers()
/*-{ return this.removable_reviewers; }-*/;
private final native NativeMap<JsArray<AccountInfo>> _reviewers()
private native NativeMap<JsArray<AccountInfo>> _reviewers()
/*-{ return this.reviewers; }-*/;
public final Map<ReviewerState, List<AccountInfo>> reviewers() {
NativeMap<JsArray<AccountInfo>> reviewers = _reviewers();
@@ -173,14 +173,14 @@ public class ChangeInfo extends JavaScriptObject {
}
return SubmitType.valueOf(submitType);
}
private final native String _submitType() /*-{ return this.submit_type; }-*/;
private native String _submitType() /*-{ return this.submit_type; }-*/;
public final boolean submittable() {
init();
return _submittable();
}
private final native boolean _submittable()
private native boolean _submittable()
/*-{ return this.submittable ? true : false; }-*/;
/**
@@ -259,7 +259,7 @@ public class ChangeInfo extends JavaScriptObject {
return null;
}
private final native NativeMap<NativeString> _values() /*-{ return this.values; }-*/;
private native NativeMap<NativeString> _values() /*-{ return this.values; }-*/;
public final Set<String> values() {
return Natives.keys(_values());
}
@@ -334,7 +334,7 @@ public class ChangeInfo extends JavaScriptObject {
revisionInfo.takeFromEdit(edit);
return revisionInfo;
}
private final native void takeFromEdit(EditInfo edit) /*-{
private native void takeFromEdit(EditInfo edit) /*-{
this._number = 0;
this.name = edit.name;
this.commit = edit.commit;
@@ -435,7 +435,7 @@ public class ChangeInfo extends JavaScriptObject {
public static class GitPerson extends JavaScriptObject {
public final native String name() /*-{ return this.name; }-*/;
public final native String email() /*-{ return this.email; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
private native String dateRaw() /*-{ return this.date; }-*/;
public final Timestamp date() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw());
@@ -449,7 +449,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native AccountInfo author() /*-{ return this.author; }-*/;
public final native String message() /*-{ return this.message; }-*/;
public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
private native String dateRaw() /*-{ return this.date; }-*/;
public final Timestamp date() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw());
@@ -475,7 +475,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native JsArrayString branches() /*-{ return this.branches; }-*/;
public final native JsArrayString tags() /*-{ return this.tags; }-*/;
public final native JsArrayString external(String n) /*-{ return this.external[n]; }-*/;
private final native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/;
private native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/;
protected IncludedInInfo() {
}

8
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java
View File

@@ -39,8 +39,8 @@ public class DownloadInfo extends JavaScriptObject {
}
public final native DownloadSchemeInfo scheme(String n) /*-{ return this.schemes[n]; }-*/;
private final native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/;
private final native JsArrayString _archives() /*-{ return this.archives; }-*/;
private native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/;
private native JsArrayString _archives() /*-{ return this.archives; }-*/;
protected DownloadInfo() {
}
@@ -96,8 +96,8 @@ public class DownloadInfo extends JavaScriptObject {
public final native boolean isAuthSupported() /*-{ return this.is_auth_supported || false; }-*/;
public final native String command(String n) /*-{ return this.commands[n]; }-*/;
public final native String cloneCommand(String n) /*-{ return this.clone_commands[n]; }-*/;
private final native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/;
private final native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/;
private native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/;
private native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/;
protected DownloadSchemeInfo() {
}

4
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java
View File

@@ -37,12 +37,12 @@ public class FileInfo extends JavaScriptObject {
public final long size() {
return (long)_size();
}
private final native double _size() /*-{ return this.size || 0; }-*/;
private native double _size() /*-{ return this.size || 0; }-*/;
public final long sizeDelta() {
return (long)_sizeDelta();
}
private final native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/;
private native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/;
public final native int _row() /*-{ return this._row }-*/;
public final native void _row(int r) /*-{ this._row = r }-*/;

32
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java
View File

@@ -65,7 +65,7 @@ public class GeneralPreferences extends JavaScriptObject {
? changesPerPage
: GeneralPreferencesInfo.DEFAULT_PAGESIZE;
}
private final native short get(String n, int d)
private native short get(String n, int d)
/*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
public final native boolean showSiteHeader()
@@ -81,21 +81,21 @@ public class GeneralPreferences extends JavaScriptObject {
String s = downloadCommandRaw();
return s != null ? DownloadCommand.valueOf(s) : null;
}
private final native String downloadCommandRaw()
private native String downloadCommandRaw()
/*-{ return this.download_command }-*/;
public final DateFormat dateFormat() {
String s = dateFormatRaw();
return s != null ? DateFormat.valueOf(s) : null;
}
private final native String dateFormatRaw()
private native String dateFormatRaw()
/*-{ return this.date_format }-*/;
public final TimeFormat timeFormat() {
String s = timeFormatRaw();
return s != null ? TimeFormat.valueOf(s) : null;
}
private final native String timeFormatRaw()
private native String timeFormatRaw()
/*-{ return this.time_format }-*/;
public final native boolean relativeDateInChangeTable()
@@ -117,14 +117,14 @@ public class GeneralPreferences extends JavaScriptObject {
String s = reviewCategeoryStrategyRaw();
return s != null ? ReviewCategoryStrategy.valueOf(s) : ReviewCategoryStrategy.NONE;
}
private final native String reviewCategeoryStrategyRaw()
private native String reviewCategeoryStrategyRaw()
/*-{ return this.review_category_strategy }-*/;
public final DiffView diffView() {
String s = diffViewRaw();
return s != null ? DiffView.valueOf(s) : null;
}
private final native String diffViewRaw()
private native String diffViewRaw()
/*-{ return this.diff_view }-*/;
public final EmailStrategy emailStrategy() {
@@ -132,7 +132,7 @@ public class GeneralPreferences extends JavaScriptObject {
return s != null ? EmailStrategy.valueOf(s) : null;
}
private final native String emailStrategyRaw()
private native String emailStrategyRaw()
/*-{ return this.email_strategy }-*/;
public final native JsArray<TopMenuItem> my()
@@ -159,13 +159,13 @@ public class GeneralPreferences extends JavaScriptObject {
public final void dateFormat(DateFormat f) {
dateFormatRaw(f != null ? f.toString() : null);
}
private final native void dateFormatRaw(String f)
private native void dateFormatRaw(String f)
/*-{ this.date_format = f }-*/;
public final void timeFormat(TimeFormat f) {
timeFormatRaw(f != null ? f.toString() : null);
}
private final native void timeFormatRaw(String f)
private native void timeFormatRaw(String f)
/*-{ this.time_format = f }-*/;
public final native void relativeDateInChangeTable(boolean d)
@@ -186,19 +186,19 @@ public class GeneralPreferences extends JavaScriptObject {
public final void reviewCategoryStrategy(ReviewCategoryStrategy s) {
reviewCategoryStrategyRaw(s != null ? s.toString() : null);
}
private final native void reviewCategoryStrategyRaw(String s)
private native void reviewCategoryStrategyRaw(String s)
/*-{ this.review_category_strategy = s }-*/;
public final void diffView(DiffView d) {
diffViewRaw(d != null ? d.toString() : null);
}
private final native void diffViewRaw(String d)
private native void diffViewRaw(String d)
/*-{ this.diff_view = d }-*/;
public final void emailStrategy(EmailStrategy s) {
emailStrategyRaw(s != null ? s.toString() : null);
}
private final native void emailStrategyRaw(String s)
private native void emailStrategyRaw(String s)
/*-{ this.email_strategy = s }-*/;
public final void setMyMenus(List<TopMenuItem> myMenus) {
@@ -218,8 +218,8 @@ public class GeneralPreferences extends JavaScriptObject {
return urlAliases;
}
private final native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/;
private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
private native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/;
private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
public final void setUrlAliases(Map<String, String> urlAliases) {
initUrlAliases();
@@ -227,8 +227,8 @@ public class GeneralPreferences extends JavaScriptObject {
putUrlAlias(e.getKey(), e.getValue());
}
}
private final native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/;
private final native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/;
private native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/;
private native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/;
protected GeneralPreferences() {
}

2
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java
View File

@@ -27,7 +27,7 @@ public class GpgKeyInfo extends JavaScriptObject {
public final native JsArrayString userIds() /*-{ return this.user_ids; }-*/;
public final native String key() /*-{ return this.key; }-*/;
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
public final Status status() {
String s = statusRaw();
if (s == null) {

2
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java
View File

@@ -43,7 +43,7 @@ public class ServerInfo extends JavaScriptObject {
}
public final native String urlAliasToken(String n) /*-{ return this.url_aliases[n]; }-*/;
private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
public final boolean hasSshd() {

6
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java
View File

@@ -22,7 +22,7 @@ public final class NativeString extends JavaScriptObject {
public static final JavaScriptObject TYPE = init();
// Used from core and plugins
private static final native JavaScriptObject init() /*-{
private static native JavaScriptObject init() /*-{
if ($wnd.Gerrit === undefined || $wnd.Gerrit.JsonString === undefined) {
return function(s){this.s=s};
} else {
@@ -34,7 +34,7 @@ public final class NativeString extends JavaScriptObject {
return wrap0(TYPE, s);
}
private static final native NativeString wrap0(JavaScriptObject T, String s)
private static native NativeString wrap0(JavaScriptObject T, String s)
/*-{ return new T(s) }-*/;
public final native String asString() /*-{ return this.s; }-*/;
@@ -58,7 +58,7 @@ public final class NativeString extends JavaScriptObject {
return is(TYPE, o);
}
private static final native boolean is(JavaScriptObject T, JavaScriptObject o)
private static native boolean is(JavaScriptObject T, JavaScriptObject o)
/*-{ return o instanceof T }-*/;
protected NativeString() {