opendev/gerrit
Code Issues Proposed changes

Remove redundant 'final' modifier from private native methods

Browse Source 
Change-Id: I882e520dcbbd5ccead63e347b9d176ff11a59b6a
This commit is contained in:
David Pursehouse
2016-04-12 10:10:07 +09:00
parent b9e1788b69
commit dfcc5cd451
43 changed files with 129 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AccountInfo.java
View File

@@ -40,9 +40,9 @@ public class AccountInfo extends JavaScriptObject {
return ts;
}
private final native String registeredOnRaw() /*-{ return this.registered_on; }-*/;
private final native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/;
private final native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/;
private native String registeredOnRaw() /*-{ return this.registered_on; }-*/;
private native Timestamp _getRegisteredOn() /*-{ return this._cts; }-*/;
private native void _setRegisteredOn(Timestamp ts) /*-{ this._cts = ts; }-*/;
/**
* @return true if the server supplied avatar information about this account.
@@ -64,7 +64,7 @@ public class AccountInfo extends JavaScriptObject {
return null;
}
private final native JsArray<AvatarInfo> avatars()
private native JsArray<AvatarInfo> avatars()
/*-{ return this.avatars }-*/;
public final native void name(String n) /*-{ this.name = n }-*/;

4
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java
View File

@@ -90,8 +90,8 @@ public class AuthInfo extends JavaScriptObject {
public final native String editFullNameUrl() /*-{ return this.edit_full_name_url; }-*/;
public final native String httpPasswordUrl() /*-{ return this.http_password_url; }-*/;
public final native boolean isGitBasicAuth() /*-{ return this.is_git_basic_auth || false; }-*/;
private final native String authTypeRaw() /*-{ return this.auth_type; }-*/;
private final native JsArrayString _editableAccountFields()
private native String authTypeRaw() /*-{ return this.auth_type; }-*/;
private native JsArrayString _editableAccountFields()
/*-{ return this.editable_account_fields; }-*/;
protected AuthInfo() {

28
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java
View File

@@ -71,8 +71,8 @@ public class ChangeInfo extends JavaScriptObject {
return revList.get(revList.length() - 1).isEdit();
}
private final native Timestamp _getCts() /*-{ return this._cts; }-*/;
private final native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/;
private native Timestamp _getCts() /*-{ return this._cts; }-*/;
private native void _setCts(Timestamp ts) /*-{ this._cts = ts; }-*/;
public final Timestamp updated() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(updatedRaw());
@@ -112,12 +112,12 @@ public class ChangeInfo extends JavaScriptObject {
public final native boolean mergeable() /*-{ return this.mergeable ? true : false; }-*/;
public final native int insertions() /*-{ return this.insertions; }-*/;
public final native int deletions() /*-{ return this.deletions; }-*/;
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
public final native String subject() /*-{ return this.subject; }-*/;
public final native AccountInfo owner() /*-{ return this.owner; }-*/;
private final native String createdRaw() /*-{ return this.created; }-*/;
private final native String updatedRaw() /*-{ return this.updated; }-*/;
private final native String submittedRaw() /*-{ return this.submitted; }-*/;
private native String createdRaw() /*-{ return this.created; }-*/;
private native String updatedRaw() /*-{ return this.updated; }-*/;
private native String submittedRaw() /*-{ return this.submitted; }-*/;
public final native boolean starred() /*-{ return this.starred ? true : false; }-*/;
public final native boolean reviewed() /*-{ return this.reviewed ? true : false; }-*/;
public final native NativeMap<LabelInfo> allLabels() /*-{ return this.labels; }-*/;
@@ -142,7 +142,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native JsArray<AccountInfo> removableReviewers()
/*-{ return this.removable_reviewers; }-*/;
private final native NativeMap<JsArray<AccountInfo>> _reviewers()
private native NativeMap<JsArray<AccountInfo>> _reviewers()
/*-{ return this.reviewers; }-*/;
public final Map<ReviewerState, List<AccountInfo>> reviewers() {
NativeMap<JsArray<AccountInfo>> reviewers = _reviewers();
@@ -173,14 +173,14 @@ public class ChangeInfo extends JavaScriptObject {
}
return SubmitType.valueOf(submitType);
}
private final native String _submitType() /*-{ return this.submit_type; }-*/;
private native String _submitType() /*-{ return this.submit_type; }-*/;
public final boolean submittable() {
init();
return _submittable();
}
private final native boolean _submittable()
private native boolean _submittable()
/*-{ return this.submittable ? true : false; }-*/;
/**
@@ -259,7 +259,7 @@ public class ChangeInfo extends JavaScriptObject {
return null;
}
private final native NativeMap<NativeString> _values() /*-{ return this.values; }-*/;
private native NativeMap<NativeString> _values() /*-{ return this.values; }-*/;
public final Set<String> values() {
return Natives.keys(_values());
}
@@ -334,7 +334,7 @@ public class ChangeInfo extends JavaScriptObject {
revisionInfo.takeFromEdit(edit);
return revisionInfo;
}
private final native void takeFromEdit(EditInfo edit) /*-{
private native void takeFromEdit(EditInfo edit) /*-{
this._number = 0;
this.name = edit.name;
this.commit = edit.commit;
@@ -435,7 +435,7 @@ public class ChangeInfo extends JavaScriptObject {
public static class GitPerson extends JavaScriptObject {
public final native String name() /*-{ return this.name; }-*/;
public final native String email() /*-{ return this.email; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
private native String dateRaw() /*-{ return this.date; }-*/;
public final Timestamp date() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw());
@@ -449,7 +449,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native AccountInfo author() /*-{ return this.author; }-*/;
public final native String message() /*-{ return this.message; }-*/;
public final native int _revisionNumber() /*-{ return this._revision_number || 0; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
private native String dateRaw() /*-{ return this.date; }-*/;
public final Timestamp date() {
return JavaSqlTimestamp_JsonSerializer.parseTimestamp(dateRaw());
@@ -475,7 +475,7 @@ public class ChangeInfo extends JavaScriptObject {
public final native JsArrayString branches() /*-{ return this.branches; }-*/;
public final native JsArrayString tags() /*-{ return this.tags; }-*/;
public final native JsArrayString external(String n) /*-{ return this.external[n]; }-*/;
private final native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/;
private native NativeMap<JsArrayString> external() /*-{ return this.external; }-*/;
protected IncludedInInfo() {
}

8
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/DownloadInfo.java
View File

@@ -39,8 +39,8 @@ public class DownloadInfo extends JavaScriptObject {
}
public final native DownloadSchemeInfo scheme(String n) /*-{ return this.schemes[n]; }-*/;
private final native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/;
private final native JsArrayString _archives() /*-{ return this.archives; }-*/;
private native NativeMap<DownloadSchemeInfo> _schemes() /*-{ return this.schemes; }-*/;
private native JsArrayString _archives() /*-{ return this.archives; }-*/;
protected DownloadInfo() {
}
@@ -96,8 +96,8 @@ public class DownloadInfo extends JavaScriptObject {
public final native boolean isAuthSupported() /*-{ return this.is_auth_supported || false; }-*/;
public final native String command(String n) /*-{ return this.commands[n]; }-*/;
public final native String cloneCommand(String n) /*-{ return this.clone_commands[n]; }-*/;
private final native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/;
private final native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/;
private native NativeMap<NativeString> _commands() /*-{ return this.commands; }-*/;
private native NativeMap<NativeString> _cloneCommands() /*-{ return this.clone_commands; }-*/;
protected DownloadSchemeInfo() {
}

4
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java
View File

@@ -37,12 +37,12 @@ public class FileInfo extends JavaScriptObject {
public final long size() {
return (long)_size();
}
private final native double _size() /*-{ return this.size || 0; }-*/;
private native double _size() /*-{ return this.size || 0; }-*/;
public final long sizeDelta() {
return (long)_sizeDelta();
}
private final native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/;
private native double _sizeDelta() /*-{ return this.size_delta || 0; }-*/;
public final native int _row() /*-{ return this._row }-*/;
public final native void _row(int r) /*-{ this._row = r }-*/;

32
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GeneralPreferences.java
View File

@@ -65,7 +65,7 @@ public class GeneralPreferences extends JavaScriptObject {
? changesPerPage
: GeneralPreferencesInfo.DEFAULT_PAGESIZE;
}
private final native short get(String n, int d)
private native short get(String n, int d)
/*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
public final native boolean showSiteHeader()
@@ -81,21 +81,21 @@ public class GeneralPreferences extends JavaScriptObject {
String s = downloadCommandRaw();
return s != null ? DownloadCommand.valueOf(s) : null;
}
private final native String downloadCommandRaw()
private native String downloadCommandRaw()
/*-{ return this.download_command }-*/;
public final DateFormat dateFormat() {
String s = dateFormatRaw();
return s != null ? DateFormat.valueOf(s) : null;
}
private final native String dateFormatRaw()
private native String dateFormatRaw()
/*-{ return this.date_format }-*/;
public final TimeFormat timeFormat() {
String s = timeFormatRaw();
return s != null ? TimeFormat.valueOf(s) : null;
}
private final native String timeFormatRaw()
private native String timeFormatRaw()
/*-{ return this.time_format }-*/;
public final native boolean relativeDateInChangeTable()
@@ -117,14 +117,14 @@ public class GeneralPreferences extends JavaScriptObject {
String s = reviewCategeoryStrategyRaw();
return s != null ? ReviewCategoryStrategy.valueOf(s) : ReviewCategoryStrategy.NONE;
}
private final native String reviewCategeoryStrategyRaw()
private native String reviewCategeoryStrategyRaw()
/*-{ return this.review_category_strategy }-*/;
public final DiffView diffView() {
String s = diffViewRaw();
return s != null ? DiffView.valueOf(s) : null;
}
private final native String diffViewRaw()
private native String diffViewRaw()
/*-{ return this.diff_view }-*/;
public final EmailStrategy emailStrategy() {
@@ -132,7 +132,7 @@ public class GeneralPreferences extends JavaScriptObject {
return s != null ? EmailStrategy.valueOf(s) : null;
}
private final native String emailStrategyRaw()
private native String emailStrategyRaw()
/*-{ return this.email_strategy }-*/;
public final native JsArray<TopMenuItem> my()
@@ -159,13 +159,13 @@ public class GeneralPreferences extends JavaScriptObject {
public final void dateFormat(DateFormat f) {
dateFormatRaw(f != null ? f.toString() : null);
}
private final native void dateFormatRaw(String f)
private native void dateFormatRaw(String f)
/*-{ this.date_format = f }-*/;
public final void timeFormat(TimeFormat f) {
timeFormatRaw(f != null ? f.toString() : null);
}
private final native void timeFormatRaw(String f)
private native void timeFormatRaw(String f)
/*-{ this.time_format = f }-*/;
public final native void relativeDateInChangeTable(boolean d)
@@ -186,19 +186,19 @@ public class GeneralPreferences extends JavaScriptObject {
public final void reviewCategoryStrategy(ReviewCategoryStrategy s) {
reviewCategoryStrategyRaw(s != null ? s.toString() : null);
}
private final native void reviewCategoryStrategyRaw(String s)
private native void reviewCategoryStrategyRaw(String s)
/*-{ this.review_category_strategy = s }-*/;
public final void diffView(DiffView d) {
diffViewRaw(d != null ? d.toString() : null);
}
private final native void diffViewRaw(String d)
private native void diffViewRaw(String d)
/*-{ this.diff_view = d }-*/;
public final void emailStrategy(EmailStrategy s) {
emailStrategyRaw(s != null ? s.toString() : null);
}
private final native void emailStrategyRaw(String s)
private native void emailStrategyRaw(String s)
/*-{ this.email_strategy = s }-*/;
public final void setMyMenus(List<TopMenuItem> myMenus) {
@@ -218,8 +218,8 @@ public class GeneralPreferences extends JavaScriptObject {
return urlAliases;
}
private final native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/;
private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
private native String urlAliasToken(String m) /*-{ return this.url_aliases[m]; }-*/;
private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
public final void setUrlAliases(Map<String, String> urlAliases) {
initUrlAliases();
@@ -227,8 +227,8 @@ public class GeneralPreferences extends JavaScriptObject {
putUrlAlias(e.getKey(), e.getValue());
}
}
private final native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/;
private final native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/;
private native void putUrlAlias(String m, String t) /*-{ this.url_aliases[m] = t; }-*/;
private native void initUrlAliases() /*-{ this.url_aliases = {}; }-*/;
protected GeneralPreferences() {
}

2
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/GpgKeyInfo.java
View File

@@ -27,7 +27,7 @@ public class GpgKeyInfo extends JavaScriptObject {
public final native JsArrayString userIds() /*-{ return this.user_ids; }-*/;
public final native String key() /*-{ return this.key; }-*/;
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
public final Status status() {
String s = statusRaw();
if (s == null) {

2
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ServerInfo.java
View File

@@ -43,7 +43,7 @@ public class ServerInfo extends JavaScriptObject {
}
public final native String urlAliasToken(String n) /*-{ return this.url_aliases[n]; }-*/;
private final native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
private native NativeMap<NativeString> _urlAliases() /*-{ return this.url_aliases; }-*/;
public final boolean hasSshd() {

6
gerrit-gwtui-common/src/main/java/com/google/gerrit/client/rpc/NativeString.java
View File

@@ -22,7 +22,7 @@ public final class NativeString extends JavaScriptObject {
public static final JavaScriptObject TYPE = init();
// Used from core and plugins
private static final native JavaScriptObject init() /*-{
private static native JavaScriptObject init() /*-{
if ($wnd.Gerrit === undefined || $wnd.Gerrit.JsonString === undefined) {
return function(s){this.s=s};
} else {
@@ -34,7 +34,7 @@ public final class NativeString extends JavaScriptObject {
return wrap0(TYPE, s);
}
private static final native NativeString wrap0(JavaScriptObject T, String s)
private static native NativeString wrap0(JavaScriptObject T, String s)
/*-{ return new T(s) }-*/;
public final native String asString() /*-{ return this.s; }-*/;
@@ -58,7 +58,7 @@ public final class NativeString extends JavaScriptObject {
return is(TYPE, o);
}
private static final native boolean is(JavaScriptObject T, JavaScriptObject o)
private static native boolean is(JavaScriptObject T, JavaScriptObject o)
/*-{ return o instanceof T }-*/;
protected NativeString() {

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/DiffPreferences.java
View File

@@ -158,11 +158,11 @@ public class DiffPreferences extends JavaScriptObject {
public final native boolean skipDeleted() /*-{ return this.skip_deleted || false }-*/;
public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/;
private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/;
private final native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/;
private final native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/;
private final native String themeRaw() /*-{ return this.theme }-*/;
private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
private native void setThemeRaw(String i) /*-{ this.theme = i }-*/;
private native void setIgnoreWhitespaceRaw(String i) /*-{ this.ignore_whitespace = i }-*/;
private native String ignoreWhitespaceRaw() /*-{ return this.ignore_whitespace }-*/;
private native String themeRaw() /*-{ return this.theme }-*/;
private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
protected DiffPreferences() {
}

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/EditPreferences.java
View File

@@ -56,12 +56,12 @@ public class EditPreferences extends JavaScriptObject {
public final void theme(Theme i) {
setThemeRaw(i != null ? i.toString() : Theme.DEFAULT.toString());
}
private final native void setThemeRaw(String i) /*-{ this.theme = i }-*/;
private native void setThemeRaw(String i) /*-{ this.theme = i }-*/;
public final void keyMapType(KeyMapType i) {
setkeyMapTypeRaw(i != null ? i.toString() : KeyMapType.DEFAULT.toString());
}
private final native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/;
private native void setkeyMapTypeRaw(String i) /*-{ this.key_map_type = i }-*/;
public final native void tabSize(int t) /*-{ this.tab_size = t }-*/;
public final native void lineLength(int c) /*-{ this.line_length = c }-*/;
@@ -78,13 +78,13 @@ public class EditPreferences extends JavaScriptObject {
String s = themeRaw();
return s != null ? Theme.valueOf(s) : Theme.DEFAULT;
}
private final native String themeRaw() /*-{ return this.theme }-*/;
private native String themeRaw() /*-{ return this.theme }-*/;
public final KeyMapType keyMapType() {
String s = keyMapTypeRaw();
return s != null ? KeyMapType.valueOf(s) : KeyMapType.DEFAULT;
}
private final native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/;
private native String keyMapTypeRaw() /*-{ return this.key_map_type }-*/;
public final int tabSize() {
return get("tab_size", 8);
@@ -105,7 +105,7 @@ public class EditPreferences extends JavaScriptObject {
public final native boolean hideLineNumbers() /*-{ return this.hide_line_numbers || false }-*/;
public final native boolean matchBrackets() /*-{ return this.match_brackets || false }-*/;
public final native boolean autoCloseBrackets() /*-{ return this.auto_close_brackets || false }-*/;
private final native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
private native int get(String n, int d) /*-{ return this.hasOwnProperty(n) ? this[n] : d }-*/;
protected EditPreferences() {
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java
View File

@@ -55,11 +55,11 @@ public class ChangeGlue {
}
}
private static final native JavaScriptObject get(String id) /*-{
private static native JavaScriptObject get(String id) /*-{
return $wnd.Gerrit.change_actions[id];
}-*/;
private static final native boolean invoke(JavaScriptObject h,
private static native boolean invoke(JavaScriptObject h,
ChangeInfo a, RevisionInfo r)
/*-{ return h(a,r) }-*/;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java
View File

@@ -45,7 +45,7 @@ public class EditGlue {
}
}
private static final native JavaScriptObject get(String id) /*-{
private static native JavaScriptObject get(String id) /*-{
return $wnd.Gerrit.edit_actions[id];
}-*/;

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionPanel.java
View File

@@ -130,14 +130,14 @@ public class ExtensionPanel extends FlowPanel {
final native void putBoolean(String k, boolean v) /*-{ this.p[k] = v; }-*/;
final native void putObject(String k, JavaScriptObject v) /*-{ this.p[k] = v; }-*/;
private static final native Context create(
private static native Context create(
JavaScriptObject T,
Definition d,
Element e)
/*-{ return new T(d,e) }-*/;
private static final JavaScriptObject TYPE = init();
private static final native JavaScriptObject init() /*-{
private static native JavaScriptObject init() /*-{
var T = function(d,e) {
this._d = d;
this._u = [];

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionScreen.java
View File

@@ -109,7 +109,7 @@ public class ExtensionScreen extends Screen {
final native void onLoad() /*-{ this._d.onLoad(this) }-*/;
final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/;
private static final native Context create(
private static native Context create(
JavaScriptObject T,
Definition d,
ExtensionScreen s,
@@ -118,7 +118,7 @@ public class ExtensionScreen extends Screen {
/*-{ return new T(d,s,e,m) }-*/;
private static final JavaScriptObject TYPE = init();
private static final native JavaScriptObject init() /*-{
private static native JavaScriptObject init() /*-{
var T = function(d,s,e,m) {
this._d = d;
this._s = s;

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ExtensionSettingsScreen.java
View File

@@ -91,7 +91,7 @@ public class ExtensionSettingsScreen extends SettingsScreen {
return Natives.keys(settingsScreens());
}
private static final native NativeMap<NativeString> settingsScreens()
private static native NativeMap<NativeString> settingsScreens()
/*-{ return $wnd.Gerrit.settingsScreens; }-*/;
public final native String getPath() /*-{ return this.path; }-*/;
@@ -114,7 +114,7 @@ public class ExtensionSettingsScreen extends SettingsScreen {
final native void onLoad() /*-{ this._d.onLoad(this) }-*/;
final native JsArray<JavaScriptObject> unload() /*-{ return this._u }-*/;
private static final native Context create(
private static native Context create(
JavaScriptObject T,
Definition d,
ExtensionSettingsScreen s,
@@ -122,7 +122,7 @@ public class ExtensionSettingsScreen extends SettingsScreen {
/*-{ return new T(d,s,e) }-*/;
private static final JavaScriptObject TYPE = init();
private static final native JavaScriptObject init() /*-{
private static native JavaScriptObject init() /*-{
var T = function(d,s,e) {
this._d = d;
this._s = s;

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java
View File

@@ -76,7 +76,7 @@ class PluginName {
protected static final native JavaScriptException makeException()
/*-{ try { null.a() } catch (e) { return e } }-*/;
private static final native boolean hasStack(JavaScriptException e)
private static native boolean hasStack(JavaScriptException e)
/*-{ return !!e.stack }-*/;
/** Extracts URL from the stack frame. */
@@ -103,7 +103,7 @@ class PluginName {
return UNKNOWN;
}
private static final native JsArrayString getStack(JavaScriptException e)
private static native JsArrayString getStack(JavaScriptException e)
/*-{ return e.stack ? e.stack.split('\n') : [] }-*/;
}
}

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java
View File

@@ -61,11 +61,11 @@ public class ProjectGlue {
}
}
private static final native JavaScriptObject projectAction(String id) /*-{
private static native JavaScriptObject projectAction(String id) /*-{
return $wnd.Gerrit.project_actions[id];
}-*/;
private static final native JavaScriptObject branchAction(String id) /*-{
private static native JavaScriptObject branchAction(String id) /*-{
return $wnd.Gerrit.branch_actions[id];
}-*/;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java
View File

@@ -46,7 +46,7 @@ public class RevisionGlue {
}
}
private static final native JavaScriptObject get(String id) /*-{
private static native JavaScriptObject get(String id) /*-{
return $wnd.Gerrit.revision_actions[id];
}-*/;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java
View File

@@ -115,7 +115,7 @@ public class FileTable extends FlowPanel {
init(DELETE, RESTORE, REVIEWED, OPEN);
}
private static final native void init(String d, String t, String r, String o) /*-{
private static native void init(String d, String t, String r, String o) /*-{
$wnd[d] = $entry(function(e,i) {
@com.google.gerrit.client.change.FileTable::onDelete(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i)
});

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java
View File

@@ -62,7 +62,7 @@ public class Hashtags extends Composite {
init(REMOVE);
}
private static final native void init(String r) /*-{
private static native void init(String r) /*-{
$wnd[r] = $entry(function(e) {
@com.google.gerrit.client.change.Hashtags::onRemove(Lcom/google/gwt/dom/client/NativeEvent;)(e)
});

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java
View File

@@ -59,7 +59,7 @@ class Labels extends Grid {
init(REMOVE_REVIEWER, REMOVE_VOTE);
}
private static final native void init(String r, String v) /*-{
private static native void init(String r, String v) /*-{
$wnd[r] = $entry(function(e) {
@com.google.gerrit.client.change.Labels::onRemoveReviewer(Lcom/google/gwt/dom/client/NativeEvent;)(e)
});

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java
View File

@@ -63,7 +63,7 @@ class PatchSetsBox extends Composite {
init(OPEN);
}
private static final native void init(String o) /*-{
private static native void init(String o) /*-{
$wnd[o] = $entry(function(e,i) {
return @com.google.gerrit.client.change.PatchSetsBox::onOpen(Lcom/google/gwt/dom/client/NativeEvent;I)(e,i);
});

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java
View File

@@ -385,7 +385,7 @@ public class RelatedChanges extends TabPanel {
String s = statusRaw();
return s != null ? Change.Status.valueOf(s) : null;
}
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
final native void setId(String i)
/*-{ if(i)this.change_id=i; }-*/;

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java
View File

@@ -67,7 +67,7 @@ class RelatedChangesTab implements IsWidget {
private static final SafeHtml POINTER_HTML =
AbstractImagePrototype.create(Gerrit.RESOURCES.arrowRight()).getSafeHtml();
private static final native String init(String o) /*-{
private static native String init(String o) /*-{
$wnd[o] = $entry(@com.google.gerrit.client.change.RelatedChangesTab::onOpen(
Lcom/google/gwt/dom/client/NativeEvent;Lcom/google/gwt/dom/client/Element;));
return o + '(event,this)';
@@ -599,7 +599,7 @@ class RelatedChangesTab implements IsWidget {
}
}
private static final native Node createDocumentFragment() /*-{
private static native Node createDocumentFragment() /*-{
return $doc.createDocumentFragment();
}-*/;
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java
View File

@@ -293,7 +293,7 @@ public class Reviewers extends Composite {
return Natives.keys(_approvals());
}
final native String approval(String l) /*-{ return this.approvals[l]; }-*/;
private final native NativeMap<NativeString> _approvals() /*-{ return this.approvals; }-*/;
private native NativeMap<NativeString> _approvals() /*-{ return this.approvals; }-*/;
protected ReviewerInfo() {
}

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/CommentInfo.java
View File

@@ -77,7 +77,7 @@ public class CommentInfo extends JavaScriptObject {
public final void side(Side side) {
sideRaw(side.toString());
}
private final native void sideRaw(String s) /*-{ this.side = s }-*/;
private native void sideRaw(String s) /*-{ this.side = s }-*/;
public final native String path() /*-{ return this.path }-*/;
public final native String id() /*-{ return this.id }-*/;
@@ -90,7 +90,7 @@ public class CommentInfo extends JavaScriptObject {
? Side.valueOf(s)
: Side.REVISION;
}
private final native String sideRaw() /*-{ return this.side }-*/;
private native String sideRaw() /*-{ return this.side }-*/;
public final Timestamp updated() {
Timestamp r = updatedTimestamp();
@@ -103,9 +103,9 @@ public class CommentInfo extends JavaScriptObject {
}
return r;
}
private final native String updatedRaw() /*-{ return this.updated }-*/;
private final native Timestamp updatedTimestamp() /*-{ return this._ts }-*/;
private final native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/;
private native String updatedRaw() /*-{ return this.updated }-*/;
private native Timestamp updatedTimestamp() /*-{ return this._ts }-*/;
private native void updatedTimestamp(Timestamp t) /*-{ this._ts = t }-*/;
public final native AccountInfo author() /*-{ return this.author }-*/;
public final native int line() /*-{ return this.line || 0 }-*/;

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ReviewInput.java
View File

@@ -42,14 +42,14 @@ public class ReviewInput extends JavaScriptObject {
public final void notify(NotifyHandling e) {
_notify(e.name());
}
private final native void _notify(String n) /*-{ this.notify=n; }-*/;
private native void _notify(String n) /*-{ this.notify=n; }-*/;
public final void drafts(DraftHandling e) {
_drafts(e.name());
}
private final native void _drafts(String n) /*-{ this.drafts=n; }-*/;
private native void _drafts(String n) /*-{ this.drafts=n; }-*/;
private final native void init() /*-{
private native void init() /*-{
this.labels = {};
this.strict_labels = true;
}-*/;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/SubmitInfo.java
View File

@@ -22,7 +22,7 @@ public class SubmitInfo extends JavaScriptObject {
return Change.Status.valueOf(statusRaw());
}
private final native String statusRaw() /*-{ return this.status; }-*/;
private native String statusRaw() /*-{ return this.status; }-*/;
protected SubmitInfo() {
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/CommentRange.java
View File

@@ -43,7 +43,7 @@ public class CommentRange extends JavaScriptObject {
public final native int endLine() /*-{ return this.end_line; }-*/;
public final native int endCharacter() /*-{ return this.end_character; }-*/;
private final native void set(int sl, int sc, int el, int ec) /*-{
private native void set(int sl, int sc, int el, int ec) /*-{
this.start_line = sl;
this.start_character = sc;
this.end_line = el;

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java
View File

@@ -66,7 +66,7 @@ public class DiffInfo extends JavaScriptObject {
public final ChangeType changeType() {
return ChangeType.valueOf(changeTypeRaw());
}
private final native String changeTypeRaw()
private native String changeTypeRaw()
/*-{ return this.change_type }-*/;
public final IntraLineStatus intralineStatus() {
@@ -75,7 +75,7 @@ public class DiffInfo extends JavaScriptObject {
? IntraLineStatus.valueOf(s)
: IntraLineStatus.OFF;
}
private final native String intralineStatusRaw()
private native String intralineStatusRaw()
/*-{ return this.intraline_status }-*/;
public final boolean hasSkip() {

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySideChunkManager.java
View File

@@ -45,7 +45,7 @@ class SideBySideChunkManager extends ChunkManager {
private static double guessedLineHeightPx = 15;
private static final JavaScriptObject focusA = initOnClick(A);
private static final JavaScriptObject focusB = initOnClick(B);
private static final native JavaScriptObject initOnClick(DisplaySide s) /*-{
private static native JavaScriptObject initOnClick(DisplaySide s) /*-{
return $entry(function(e){
@com.google.gerrit.client.diff.SideBySideChunkManager::focus(
Lcom/google/gwt/dom/client/NativeEvent;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/UnifiedChunkManager.java
View File

@@ -38,7 +38,7 @@ import java.util.List;
/** Colors modified regions for {@link Unified}. */
class UnifiedChunkManager extends ChunkManager {
private static final JavaScriptObject focus = initOnClick();
private static final native JavaScriptObject initOnClick() /*-{
private static native JavaScriptObject initOnClick() /*-{
return $entry(function(e){
@com.google.gerrit.client.diff.UnifiedChunkManager::focus(
Lcom/google/gwt/dom/client/NativeEvent;)(e)

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupAuditEventInfo.java
View File

@@ -37,8 +37,8 @@ public class GroupAuditEventInfo extends JavaScriptObject {
public final native AccountInfo memberAsUser() /*-{ return this.member; }-*/;
public final native GroupInfo memberAsGroup() /*-{ return this.member; }-*/;
private final native String dateRaw() /*-{ return this.date; }-*/;
private final native String typeRaw() /*-{ return this.type; }-*/;
private native String dateRaw() /*-{ return this.date; }-*/;
private native String typeRaw() /*-{ return this.type; }-*/;
protected GroupAuditEventInfo() {
}

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/groups/GroupInfo.java
View File

@@ -33,9 +33,9 @@ public class GroupInfo extends GroupBaseInfo {
public final native JsArray<AccountInfo> members() /*-{ return this.members; }-*/;
public final native JsArray<GroupInfo> includes() /*-{ return this.includes; }-*/;
private final native int group_id() /*-{ return this.group_id; }-*/;
private final native String owner_id() /*-{ return this.owner_id; }-*/;
private final native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/;
private native int group_id() /*-{ return this.group_id; }-*/;
private native String owner_id() /*-{ return this.owner_id; }-*/;
private native void owner_id(String o) /*-{ if(o)this.owner_id=o; }-*/;
public final AccountGroup.UUID getOwnerUUID() {
String owner = owner_id();

8
gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java
View File

@@ -69,7 +69,7 @@ public class ConfigInfo extends JavaScriptObject {
public final native NativeMap<ActionInfo> actions()
/*-{ return this.actions; }-*/;
private final native String submitTypeRaw()
private native String submitTypeRaw()
/*-{ return this.submit_type }-*/;
public final ProjectState state() {
@@ -78,13 +78,13 @@ public class ConfigInfo extends JavaScriptObject {
}
return ProjectState.valueOf(stateRaw());
}
private final native String stateRaw()
private native String stateRaw()
/*-{ return this.state }-*/;
public final native MaxObjectSizeLimitInfo maxObjectSizeLimit()
/*-{ return this.max_object_size_limit; }-*/;
private final native NativeMap<CommentLinkInfo> commentlinks0()
private native NativeMap<CommentLinkInfo> commentlinks0()
/*-{ return this.commentlinks; }-*/;
final List<FindReplace> commentlinks() {
JsArray<CommentLinkInfo> cls = commentlinks0().values();
@@ -143,7 +143,7 @@ public class ConfigInfo extends JavaScriptObject {
public final InheritableBoolean configuredValue() {
return InheritableBoolean.valueOf(configuredValueRaw());
}
private final native String configuredValueRaw()
private native String configuredValueRaw()
/*-{ return this.configured_value }-*/;
public final void setConfiguredValue(InheritableBoolean v) {

20
gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectApi.java
View File

@@ -228,43 +228,43 @@ public class ProjectApi {
final void setUseContributorAgreements(InheritableBoolean v) {
setUseContributorAgreementsRaw(v.name());
}
private final native void setUseContributorAgreementsRaw(String v)
private native void setUseContributorAgreementsRaw(String v)
/*-{ if(v)this.use_contributor_agreements=v; }-*/;
final void setUseContentMerge(InheritableBoolean v) {
setUseContentMergeRaw(v.name());
}
private final native void setUseContentMergeRaw(String v)
private native void setUseContentMergeRaw(String v)
/*-{ if(v)this.use_content_merge=v; }-*/;
final void setUseSignedOffBy(InheritableBoolean v) {
setUseSignedOffByRaw(v.name());
}
private final native void setUseSignedOffByRaw(String v)
private native void setUseSignedOffByRaw(String v)
/*-{ if(v)this.use_signed_off_by=v; }-*/;
final void setRequireChangeId(InheritableBoolean v) {
setRequireChangeIdRaw(v.name());
}
private final native void setRequireChangeIdRaw(String v)
private native void setRequireChangeIdRaw(String v)
/*-{ if(v)this.require_change_id=v; }-*/;
final void setCreateNewChangeForAllNotInTarget(InheritableBoolean v) {
setCreateNewChangeForAllNotInTargetRaw(v.name());
}
private final native void setCreateNewChangeForAllNotInTargetRaw(String v)
private native void setCreateNewChangeForAllNotInTargetRaw(String v)
/*-{ if(v)this.create_new_change_for_all_not_in_target=v; }-*/;
final void setEnableSignedPush(InheritableBoolean v) {
setEnableSignedPushRaw(v.name());
}
private final native void setEnableSignedPushRaw(String v)
private native void setEnableSignedPushRaw(String v)
/*-{ if(v)this.enable_signed_push=v; }-*/;
final void setRequireSignedPush(InheritableBoolean v) {
setRequireSignedPushRaw(v.name());
}
private final native void setRequireSignedPushRaw(String v)
private native void setRequireSignedPushRaw(String v)
/*-{ if(v)this.require_signed_push=v; }-*/;
final native void setMaxObjectSizeLimit(String l)
@@ -273,13 +273,13 @@ public class ProjectApi {
final void setSubmitType(SubmitType t) {
setSubmitTypeRaw(t.name());
}
private final native void setSubmitTypeRaw(String t)
private native void setSubmitTypeRaw(String t)
/*-{ if(t)this.submit_type=t; }-*/;
final void setState(ProjectState s) {
setStateRaw(s.name());
}
private final native void setStateRaw(String s)
private native void setStateRaw(String s)
/*-{ if(s)this.state=s; }-*/;
final void setPluginConfigValues(Map<String, Map<String, ConfigParameterValue>> pluginConfigValues) {
@@ -295,7 +295,7 @@ public class ProjectApi {
setPluginConfigValuesRaw(configValues);
}
}
private final native void setPluginConfigValuesRaw(NativeMap<ConfigParameterValueMap> v)
private native void setPluginConfigValuesRaw(NativeMap<ConfigParameterValueMap> v)
/*-{ this.plugin_config_values=v; }-*/;
}

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java
View File

@@ -36,7 +36,7 @@ public class ProjectInfo
return ProjectState.valueOf(getStringState());
}
private final native String getStringState() /*-{ return this.state; }-*/;
private native String getStringState() /*-{ return this.state; }-*/;
@Override
public final String getDisplayString() {

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java
View File

@@ -222,9 +222,9 @@ public abstract class FancyFlexTable<RowItem> extends Composite {
protected static class MyFlexTable extends FlexTable {
}
private static final native <ItemType> void setRowItem(Element td, ItemType c)
private static native <ItemType> void setRowItem(Element td, ItemType c)
/*-{ td['__gerritRowItem'] = c; }-*/;
private static final native <ItemType> ItemType getRowItem(Element td)
private static native <ItemType> ItemType getRowItem(Element td)
/*-{ return td['__gerritRowItem']; }-*/;
}

8
gerrit-gwtui/src/main/java/net/codemirror/lib/CodeMirror.java vendored
View File

@@ -138,7 +138,7 @@ public class CodeMirror extends JavaScriptObject {
addLineClassNative(line, where.value(), className);
}
private final native void addLineClassNative(int line, String where,
private native void addLineClassNative(int line, String where,
String lineClass) /*-{
this.addLineClass(line, where, lineClass)
}-*/;
@@ -148,7 +148,7 @@ public class CodeMirror extends JavaScriptObject {
addLineClassNative(line, where.value(), className);
}
private final native void addLineClassNative(LineHandle line, String where,
private native void addLineClassNative(LineHandle line, String where,
String lineClass) /*-{
this.addLineClass(line, where, lineClass)
}-*/;
@@ -158,7 +158,7 @@ public class CodeMirror extends JavaScriptObject {
removeLineClassNative(line, where.value(), className);
}
private final native void removeLineClassNative(int line, String where,
private native void removeLineClassNative(int line, String where,
String lineClass) /*-{
this.removeLineClass(line, where, lineClass)
}-*/;
@@ -168,7 +168,7 @@ public class CodeMirror extends JavaScriptObject {
removeLineClassNative(line, where.value(), className);
}
private final native void removeLineClassNative(LineHandle line, String where,
private native void removeLineClassNative(LineHandle line, String where,
String lineClass) /*-{
this.removeLineClass(line, where, lineClass)
}-*/;

2
gerrit-gwtui/src/main/java/net/codemirror/lib/Extras.java vendored
View File

@@ -30,7 +30,7 @@ import java.util.Objects;
/** Additional features added to CodeMirror by Gerrit Code Review. */
public class Extras {
static final native Extras get(CodeMirror c) /*-{ return c.gerritExtras }-*/;
private static final native void set(CodeMirror c, Extras e)
private static native void set(CodeMirror c, Extras e)
/*-{ c.gerritExtras = e }-*/;
static void attach(CodeMirror c) {

2
gerrit-gwtui/src/main/java/net/codemirror/mode/ModeInfo.java vendored
View File

@@ -258,7 +258,7 @@ public class ModeInfo extends JavaScriptObject {
public final native JsArrayString mimes()
/*-{ return this.mimes || [this.mime] }-*/;
private final native JsArrayString ext()
private native JsArrayString ext()
/*-{ return this.ext || [] }-*/;
protected ModeInfo() {

14
gerrit-plugin-gwtui/src/main/java/com/google/gerrit/plugin/client/Plugin.java
View File

@@ -94,7 +94,7 @@ public final class Plugin extends JavaScriptObject {
screen(token, wrap(entry));
}
private final native void screen(String t, JavaScriptObject e)
private native void screen(String t, JavaScriptObject e)
/*-{ this.screen(t, e) }-*/;
/**
@@ -109,7 +109,7 @@ public final class Plugin extends JavaScriptObject {
screenRegex(regex, wrap(entry));
}
private final native void screenRegex(String p, JavaScriptObject e)
private native void screenRegex(String p, JavaScriptObject e)
/*-{ this.screen(new $wnd.RegExp(p), e) }-*/;
/**
@@ -122,7 +122,7 @@ public final class Plugin extends JavaScriptObject {
settingsScreen(token, menu, wrap(entry));
}
private final native void settingsScreen(String t, String m, JavaScriptObject e)
private native void settingsScreen(String t, String m, JavaScriptObject e)
/*-{ this.settingsScreen(t, m, e) }-*/;
/**
@@ -136,7 +136,7 @@ public final class Plugin extends JavaScriptObject {
panel(extensionPoint.name(), wrap(entry));
}
private final native void panel(String i, JavaScriptObject e)
private native void panel(String i, JavaScriptObject e)
/*-{ this.panel(i, e) }-*/;
protected Plugin() {
@@ -144,17 +144,17 @@ public final class Plugin extends JavaScriptObject {
native void _initialized() /*-{ this._success = true }-*/;
native void _loaded() /*-{ this._loadedGwt() }-*/;
private static final native Plugin install(String u)
private static native Plugin install(String u)
/*-{ return $wnd.Gerrit.installGwt(u) }-*/;
private static final native JavaScriptObject wrap(Screen.EntryPoint b) /*-{
private static native JavaScriptObject wrap(Screen.EntryPoint b) /*-{
return $entry(function(c){
b.@com.google.gerrit.plugin.client.screen.Screen.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/screen/Screen;)(
@com.google.gerrit.plugin.client.screen.Screen::new(Lcom/google/gerrit/plugin/client/screen/Screen$Context;)(c));
});
}-*/;
private static final native JavaScriptObject wrap(Panel.EntryPoint b) /*-{
private static native JavaScriptObject wrap(Panel.EntryPoint b) /*-{
return $entry(function(c){
b.@com.google.gerrit.plugin.client.extension.Panel.EntryPoint::onLoad(Lcom/google/gerrit/plugin/client/extension/Panel;)(
@com.google.gerrit.plugin.client.extension.Panel::new(Lcom/google/gerrit/plugin/client/extension/Panel$Context;)(c));