opendev/gerrit
Code Issues Proposed changes

Fix improper event reference for Safari

Browse Source 
The keyboard shortcut behavior's shouldSuppressKeyboardShortcut method
mistakenly referred to the source event via `window.event`, but still
worked in browsers that provide `window.event` for legacy reasons.

Bug: Issue 6759
Change-Id: Iba97ffb3f9a073439af03e74466756138dcadeb2
This commit is contained in:
Wyatt Allen
2017-07-18 09:51:59 -07:00
parent b267eb5819
commit e11088a8d2
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.html
View File

@@ -42,7 +42,7 @@ limitations under the License.
shouldSuppressKeyboardShortcut(e) {
e = getKeyboardEvent(e);
const tagName = Polymer.dom(event).rootTarget.tagName;
const tagName = Polymer.dom(e).rootTarget.tagName;
if (tagName === 'INPUT' || tagName === 'TEXTAREA') {
return true;
}

4
polygerrit-ui/app/elements/admin/gr-project-detail-list/gr-project-detail-list.js
View File

@@ -166,8 +166,8 @@
this._isEditing = false;
},
_handleSaveRevision() {
this._setProjectHead(this._project, this._revisedRef, event);
_handleSaveRevision(e) {
this._setProjectHead(this._project, this._revisedRef, e);
},
_setProjectHead(project, ref, event) {