opendev/gerrit
Code Issues Proposed changes

Initial change messages should go with the insert

Browse Source 
Join these together into one batch write to the database
when running on gerrit-review.

Change-Id: I25e473854c6bdd707fd105dd71fe3533c34c26c4
This commit is contained in:
Shawn Pearce
2013-12-06 11:30:15 -08:00
parent a3f72e4bb8
commit ee6bbd43e5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeInserter.java
View File

@@ -162,13 +162,13 @@ public class ChangeInserter {
LabelTypes labelTypes = refControl.getProjectControl().getLabelTypes();
approvalsUtil.addReviewers(labelTypes, change, patchSet, patchSetInfo,
reviewers, Collections.<Account.Id> emptySet());
if (changeMessage != null) {
db.changeMessages().insert(Collections.singleton(changeMessage));
}
db.commit();
} finally {
db.rollback();
}
if (changeMessage != null) {
db.changeMessages().insert(Collections.singleton(changeMessage));
}
CheckedFuture<?, IOException> f =
mergeabilityChecker.updateAndIndexAsync(change);